From ca3117264a99ba634f7a8d70cd3bb6dc91df6664 Mon Sep 17 00:00:00 2001 From: marracuene Date: Sat, 20 Jun 2020 10:06:52 +0200 Subject: [PATCH 01/18] If build fails, upload test reports as an artifact, so that they can be investigated. See https://github.com/gradle/playframework/issues/136 Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 4576e6b3..1356d06a 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -15,3 +15,8 @@ jobs: - uses: eskatos/gradle-command-action@v1 with: arguments: ${{ matrix.task }} + - uses: actions/upload-artifact@v2 + if: failure() + with: + name: testreports + path: build/reports/tests # or path/to/artifact \ No newline at end of file From 74209915be868dd1e57424c7fca480cce970f40b Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 11:03:08 +0200 Subject: [PATCH 02/18] Added comments Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 1356d06a..835a2140 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -12,11 +12,13 @@ jobs: - uses: actions/setup-java@v1 with: java-version: 8 + #run the build - uses: eskatos/gradle-command-action@v1 with: arguments: ${{ matrix.task }} + #upload build reports for later inspection - uses: actions/upload-artifact@v2 if: failure() with: name: testreports - path: build/reports/tests # or path/to/artifact \ No newline at end of file + path: build/reports/tests \ No newline at end of file From 7ac179f89b2373735e4737a9638d9089e901073d Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 11:07:09 +0200 Subject: [PATCH 03/18] Alter syntax Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 835a2140..80c71ba9 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -18,7 +18,7 @@ jobs: arguments: ${{ matrix.task }} #upload build reports for later inspection - uses: actions/upload-artifact@v2 - if: failure() + # if: failure() with: name: testreports path: build/reports/tests \ No newline at end of file From 26a9e78d19448564628b5b3faa98a860908166c6 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 11:10:34 +0200 Subject: [PATCH 04/18] Alter syntax Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 80c71ba9..e3456f48 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -12,13 +12,12 @@ jobs: - uses: actions/setup-java@v1 with: java-version: 8 - #run the build + # run the build - uses: eskatos/gradle-command-action@v1 with: arguments: ${{ matrix.task }} - #upload build reports for later inspection + # upload build reports for later inspection - uses: actions/upload-artifact@v2 - # if: failure() with: name: testreports path: build/reports/tests \ No newline at end of file From 4b5a41931e691c6157d4d20f393f25fb00a93076 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 11:15:40 +0200 Subject: [PATCH 05/18] Alter syntax Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index e3456f48..6302252e 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -18,6 +18,6 @@ jobs: arguments: ${{ matrix.task }} # upload build reports for later inspection - uses: actions/upload-artifact@v2 - with: + with: name: testreports path: build/reports/tests \ No newline at end of file From f77303041a902520363500109ce38bf3df035dbc Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 12:06:46 +0200 Subject: [PATCH 06/18] Restrict to only integrationTests Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 6302252e..407228d5 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -5,7 +5,8 @@ jobs: gradle: strategy: matrix: - task: [integrationTest, docTest] + # task: [integrationTest, docTest] + task: [integrationTest] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -18,6 +19,7 @@ jobs: arguments: ${{ matrix.task }} # upload build reports for later inspection - uses: actions/upload-artifact@v2 + if: failure() with: name: testreports path: build/reports/tests \ No newline at end of file From 67b8f602d893c1ae2b31dfe8127461a241514776 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 12:43:34 +0200 Subject: [PATCH 07/18] Restrict to only integrationTests Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 407228d5..b5f253a3 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -5,8 +5,7 @@ jobs: gradle: strategy: matrix: - # task: [integrationTest, docTest] - task: [integrationTest] + task: [docTest, integrationTest] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -17,7 +16,8 @@ jobs: - uses: eskatos/gradle-command-action@v1 with: arguments: ${{ matrix.task }} - # upload build reports for later inspection + # upload build reports for later inspection, if the build failed + # N.B only applies to the last task in the matrix - uses: actions/upload-artifact@v2 if: failure() with: From 3fc784d8eec8419abbc4c0451b6731b7bfc0d560 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 18:08:12 +0200 Subject: [PATCH 08/18] If build fails, upload test reports as an artifact, so that they can be investigated. See https://github.com/gradle/playframework/issues/136 --- .github/workflows/gradle-build-pr.yml | 3 ++- gradle.properties | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index b5f253a3..1f4e39f4 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -5,7 +5,8 @@ jobs: gradle: strategy: matrix: - task: [docTest, integrationTest] + #task: [docTest, integrationTest] + task: [integrationTest] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 diff --git a/gradle.properties b/gradle.properties index 5dc333bf..a1e3f42d 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,2 +1,2 @@ systemProp.gradle.publish.skip.namespace.check=true -org.gradle.caching=true +org.gradle.caching=false From 20064773c06626c97cd64b0143401b0ca9b4090a Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 19:37:14 +0200 Subject: [PATCH 09/18] set maxParallelForks to 1 --- build.gradle.kts | 122 ++++++++++++++++++++++++++--------------------- 1 file changed, 68 insertions(+), 54 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index ef89b4e5..e3dcea9f 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -34,67 +34,81 @@ java { targetCompatibility = JavaVersion.VERSION_1_8 } -gradlePlugin { - testSourceSets(sourceSets.integTest.get(), sourceSets.docTest.get()) - - plugins { - register("play-twirl-plugin") { - id = "org.gradle.playframework-twirl" - displayName = "Play Twirl Plugin" - description = "Plugin for compiling Twirl sources in a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayTwirlPlugin" - } +tasks.named("integrationTest") { + maxParallelForks = 1 +} - register("play-routes-plugin") { - id = "org.gradle.playframework-routes" - displayName = "Play Routes Plugin" - description = "Plugin for compiling Play routes sources in a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayRoutesPlugin" - } +tasks.named("docTest") { + maxParallelForks = 1 +} - register("play-application-plugin") { - id = "org.gradle.playframework-application" - displayName = "Play Application Plugin" - description = "Plugin for building a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayApplicationPlugin" - } - register("play-javascript-plugin") { - id = "org.gradle.playframework-javascript" - displayName = "Play JavaScript Plugin" - description = "Plugin for adding JavaScript processing to a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayJavaScriptPlugin" - } +tasks.named("javadoc") { + enabled = true +} - register("play-distribution-plugin") { - id = "org.gradle.playframework-distribution" - displayName = "Play Distribution Plugin" - description = "Plugin for generating distributions for Play applications." - implementationClass = "org.gradle.playframework.plugins.PlayDistributionPlugin" - } + gradlePlugin { + testSourceSets(sourceSets.integTest.get(), sourceSets.docTest.get()) - register("play-ide-plugin") { - id = "org.gradle.playframework-ide" - displayName = "Play IDE Plugin" - description = "Plugin for generating IDE project files for Play applications." - implementationClass = "org.gradle.playframework.plugins.PlayIdePlugin" - } + plugins { + register("play-twirl-plugin") { + id = "org.gradle.playframework-twirl" + displayName = "Play Twirl Plugin" + description = "Plugin for compiling Twirl sources in a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayTwirlPlugin" + } - register("play-plugin") { - id = "org.gradle.playframework" - displayName = "Play Plugin" - description = "Plugin that supports building, testing and running Play applications with Gradle." - implementationClass = "org.gradle.playframework.plugins.PlayPlugin" + register("play-routes-plugin") { + id = "org.gradle.playframework-routes" + displayName = "Play Routes Plugin" + description = "Plugin for compiling Play routes sources in a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayRoutesPlugin" + } + + register("play-application-plugin") { + id = "org.gradle.playframework-application" + displayName = "Play Application Plugin" + description = "Plugin for building a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayApplicationPlugin" + } + + register("play-javascript-plugin") { + id = "org.gradle.playframework-javascript" + displayName = "Play JavaScript Plugin" + description = "Plugin for adding JavaScript processing to a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayJavaScriptPlugin" + } + + register("play-distribution-plugin") { + id = "org.gradle.playframework-distribution" + displayName = "Play Distribution Plugin" + description = "Plugin for generating distributions for Play applications." + implementationClass = "org.gradle.playframework.plugins.PlayDistributionPlugin" + } + + register("play-ide-plugin") { + id = "org.gradle.playframework-ide" + displayName = "Play IDE Plugin" + description = "Plugin for generating IDE project files for Play applications." + implementationClass = "org.gradle.playframework.plugins.PlayIdePlugin" + } + + register("play-plugin") { + id = "org.gradle.playframework" + displayName = "Play Plugin" + description = "Plugin that supports building, testing and running Play applications with Gradle." + implementationClass = "org.gradle.playframework.plugins.PlayPlugin" + } } } -} -pluginBundle { - website = "https://gradle.github.io/playframework/" - vcsUrl = "https://github.com/gradle/playframework" - tags = listOf("playframework", "web", "java", "scala") - mavenCoordinates { - groupId = project.group.toString() - artifactId = base.archivesBaseName + pluginBundle { + website = "https://gradle.github.io/playframework/" + vcsUrl = "https://github.com/gradle/playframework" + tags = listOf("playframework", "web", "java", "scala") + mavenCoordinates { + groupId = project.group.toString() + artifactId = base.archivesBaseName + } } -} + From 5d5c2615035d8210e055b0a021e120332c4a3117 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 21:22:36 +0200 Subject: [PATCH 10/18] Run only one test --- .github/workflows/gradle-build-pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 1f4e39f4..faf4d7b6 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -16,8 +16,8 @@ jobs: # run the build - uses: eskatos/gradle-command-action@v1 with: - arguments: ${{ matrix.task }} - # upload build reports for later inspection, if the build failed + arguments: integrationTest --tests org.gradle.playframework.application.advanced.PlayIdeaPluginAdvancedIntegrationTest + # upload build reports for later inspection, if the build failed # N.B only applies to the last task in the matrix - uses: actions/upload-artifact@v2 if: failure() From c82fb90c7efadc3763825dc346177a74480bef8c Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 21:44:10 +0200 Subject: [PATCH 11/18] Run only one test - forcing rerun --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index faf4d7b6..4add74b5 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -18,7 +18,7 @@ jobs: with: arguments: integrationTest --tests org.gradle.playframework.application.advanced.PlayIdeaPluginAdvancedIntegrationTest # upload build reports for later inspection, if the build failed - # N.B only applies to the last task in the matrix + # N.B only applies to the last task in the matrix - uses: actions/upload-artifact@v2 if: failure() with: From 290a6d97b87276f7f2dff31edb0abd04e46dd111 Mon Sep 17 00:00:00 2001 From: marracuene Date: Tue, 23 Jun 2020 22:19:21 +0200 Subject: [PATCH 12/18] Now upload entire build folder --- .github/workflows/gradle-build-pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 4add74b5..294149e9 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -22,5 +22,5 @@ jobs: - uses: actions/upload-artifact@v2 if: failure() with: - name: testreports - path: build/reports/tests \ No newline at end of file + name: wholebuild #testreports + path: build #build/reports/tests \ No newline at end of file From 06af4801361eebbea5b32f63516c73de314718ab Mon Sep 17 00:00:00 2001 From: marracuene Date: Wed, 24 Jun 2020 12:55:40 +0200 Subject: [PATCH 13/18] Run integrationTest last (as it is the one failing), then upload entire build folder as artifact. See: https://github.com/gradle/playframework/issues/136 Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 294149e9..d33ea102 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -5,8 +5,7 @@ jobs: gradle: strategy: matrix: - #task: [docTest, integrationTest] - task: [integrationTest] + task: [docTest, integrationTest] runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -16,9 +15,9 @@ jobs: # run the build - uses: eskatos/gradle-command-action@v1 with: - arguments: integrationTest --tests org.gradle.playframework.application.advanced.PlayIdeaPluginAdvancedIntegrationTest - # upload build reports for later inspection, if the build failed - # N.B only applies to the last task in the matrix + arguments: ${{ matrix.task }} + # upload build output for later inspection, if the build failed + # N.B only applies to the last task in the matrix - uses: actions/upload-artifact@v2 if: failure() with: From 5601344696b918b7770ee9e23e6e03f683418b07 Mon Sep 17 00:00:00 2001 From: marracuene Date: Wed, 24 Jun 2020 13:03:49 +0200 Subject: [PATCH 14/18] Remove tweaks to build caching/forking. Signed-off-by: marracuene --- build.gradle.kts | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index e3dcea9f..2be95630 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -34,19 +34,6 @@ java { targetCompatibility = JavaVersion.VERSION_1_8 } -tasks.named("integrationTest") { - maxParallelForks = 1 -} - -tasks.named("docTest") { - maxParallelForks = 1 -} - - -tasks.named("javadoc") { - enabled = true -} - gradlePlugin { testSourceSets(sourceSets.integTest.get(), sourceSets.docTest.get()) From 079d06a9b76303a61b9239d8728daa05efff66e5 Mon Sep 17 00:00:00 2001 From: marracuene Date: Wed, 24 Jun 2020 13:09:06 +0200 Subject: [PATCH 15/18] Remove tweaks to build caching/forking. Signed-off-by: marracuene --- build.gradle.kts | 107 +++++++++++++++++++++++----------------------- gradle.properties | 2 +- 2 files changed, 54 insertions(+), 55 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index 2be95630..ef89b4e5 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -34,68 +34,67 @@ java { targetCompatibility = JavaVersion.VERSION_1_8 } - gradlePlugin { - testSourceSets(sourceSets.integTest.get(), sourceSets.docTest.get()) +gradlePlugin { + testSourceSets(sourceSets.integTest.get(), sourceSets.docTest.get()) - plugins { - register("play-twirl-plugin") { - id = "org.gradle.playframework-twirl" - displayName = "Play Twirl Plugin" - description = "Plugin for compiling Twirl sources in a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayTwirlPlugin" - } - - register("play-routes-plugin") { - id = "org.gradle.playframework-routes" - displayName = "Play Routes Plugin" - description = "Plugin for compiling Play routes sources in a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayRoutesPlugin" - } + plugins { + register("play-twirl-plugin") { + id = "org.gradle.playframework-twirl" + displayName = "Play Twirl Plugin" + description = "Plugin for compiling Twirl sources in a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayTwirlPlugin" + } - register("play-application-plugin") { - id = "org.gradle.playframework-application" - displayName = "Play Application Plugin" - description = "Plugin for building a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayApplicationPlugin" - } + register("play-routes-plugin") { + id = "org.gradle.playframework-routes" + displayName = "Play Routes Plugin" + description = "Plugin for compiling Play routes sources in a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayRoutesPlugin" + } - register("play-javascript-plugin") { - id = "org.gradle.playframework-javascript" - displayName = "Play JavaScript Plugin" - description = "Plugin for adding JavaScript processing to a Play application." - implementationClass = "org.gradle.playframework.plugins.PlayJavaScriptPlugin" - } + register("play-application-plugin") { + id = "org.gradle.playframework-application" + displayName = "Play Application Plugin" + description = "Plugin for building a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayApplicationPlugin" + } - register("play-distribution-plugin") { - id = "org.gradle.playframework-distribution" - displayName = "Play Distribution Plugin" - description = "Plugin for generating distributions for Play applications." - implementationClass = "org.gradle.playframework.plugins.PlayDistributionPlugin" - } + register("play-javascript-plugin") { + id = "org.gradle.playframework-javascript" + displayName = "Play JavaScript Plugin" + description = "Plugin for adding JavaScript processing to a Play application." + implementationClass = "org.gradle.playframework.plugins.PlayJavaScriptPlugin" + } - register("play-ide-plugin") { - id = "org.gradle.playframework-ide" - displayName = "Play IDE Plugin" - description = "Plugin for generating IDE project files for Play applications." - implementationClass = "org.gradle.playframework.plugins.PlayIdePlugin" - } + register("play-distribution-plugin") { + id = "org.gradle.playframework-distribution" + displayName = "Play Distribution Plugin" + description = "Plugin for generating distributions for Play applications." + implementationClass = "org.gradle.playframework.plugins.PlayDistributionPlugin" + } - register("play-plugin") { - id = "org.gradle.playframework" - displayName = "Play Plugin" - description = "Plugin that supports building, testing and running Play applications with Gradle." - implementationClass = "org.gradle.playframework.plugins.PlayPlugin" - } + register("play-ide-plugin") { + id = "org.gradle.playframework-ide" + displayName = "Play IDE Plugin" + description = "Plugin for generating IDE project files for Play applications." + implementationClass = "org.gradle.playframework.plugins.PlayIdePlugin" } - } - pluginBundle { - website = "https://gradle.github.io/playframework/" - vcsUrl = "https://github.com/gradle/playframework" - tags = listOf("playframework", "web", "java", "scala") - mavenCoordinates { - groupId = project.group.toString() - artifactId = base.archivesBaseName + register("play-plugin") { + id = "org.gradle.playframework" + displayName = "Play Plugin" + description = "Plugin that supports building, testing and running Play applications with Gradle." + implementationClass = "org.gradle.playframework.plugins.PlayPlugin" } } +} +pluginBundle { + website = "https://gradle.github.io/playframework/" + vcsUrl = "https://github.com/gradle/playframework" + tags = listOf("playframework", "web", "java", "scala") + mavenCoordinates { + groupId = project.group.toString() + artifactId = base.archivesBaseName + } +} diff --git a/gradle.properties b/gradle.properties index a1e3f42d..5dc333bf 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,2 +1,2 @@ systemProp.gradle.publish.skip.namespace.check=true -org.gradle.caching=false +org.gradle.caching=true From 9fa56ae7c2fcde5b5d3cb8c352537dfa24493de0 Mon Sep 17 00:00:00 2001 From: marracuene Date: Fri, 26 Jun 2020 16:23:56 +0200 Subject: [PATCH 16/18] Pin eskatos/gradle-command-action to v1.2 See: https://github.com/eskatos/gradle-command-action/issues/22 Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index d33ea102..1fd239c8 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -13,7 +13,7 @@ jobs: with: java-version: 8 # run the build - - uses: eskatos/gradle-command-action@v1 + - uses: eskatos/gradle-command-action@v1.2 with: arguments: ${{ matrix.task }} # upload build output for later inspection, if the build failed From 9cdb20d5a4e3b5af7948e1c06d6663aea1cfdeee Mon Sep 17 00:00:00 2001 From: marracuene Date: Fri, 26 Jun 2020 16:26:08 +0200 Subject: [PATCH 17/18] Pin eskatos/gradle-command-action to v1.2.0 See: https://github.com/eskatos/gradle-command-action/issues/22 Signed-off-by: marracuene --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index 1fd239c8..d555ef46 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -13,7 +13,7 @@ jobs: with: java-version: 8 # run the build - - uses: eskatos/gradle-command-action@v1.2 + - uses: eskatos/gradle-command-action@v1.2.0 with: arguments: ${{ matrix.task }} # upload build output for later inspection, if the build failed From 196e0578125d80f3de246eeecddcc9fd9e2d3ffb Mon Sep 17 00:00:00 2001 From: Cameron Smith <66551006+marracuene@users.noreply.github.com> Date: Wed, 1 Jul 2020 23:22:18 +0200 Subject: [PATCH 18/18] Add EOL at EOF Co-authored-by: Jonathan Leitschuh --- .github/workflows/gradle-build-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/gradle-build-pr.yml b/.github/workflows/gradle-build-pr.yml index d555ef46..edd6ec34 100644 --- a/.github/workflows/gradle-build-pr.yml +++ b/.github/workflows/gradle-build-pr.yml @@ -22,4 +22,4 @@ jobs: if: failure() with: name: wholebuild #testreports - path: build #build/reports/tests \ No newline at end of file + path: build #build/reports/tests