Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds GCC recognized c++ src code file extensions #29672

Closed
wants to merge 1 commit into from

Conversation

premsair
Copy link

Fixes gradle/gradle-native#1113

Context

Various people use various extensions for c++ source code. Gradle restricting to compile only specific extensions would force the users of Gradle building c++ projects to rename the extensions of their entire c++ source code base which is sometimes very large. This change would provide nice experience to adopt Gradle for building c++ projects.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@premsair premsair requested a review from a team as a code owner June 24, 2024 16:09
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Jun 24, 2024
@hegyibalint
Copy link
Member

Thank you for your contribution!

The DCO check is failing, please look into that as we can't accept the PR otherwise.

@hegyibalint hegyibalint added in:native-platform c, cpp, swift and other native languages support, etc pending:dco PR DCO check is failing, commits need to be signed off to-triage and removed to-triage labels Jun 25, 2024
Copy link
Member

@ov7a ov7a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This cp extension looks weird. Is it a typo, or you can provide some source for that convention? (Technically, GCC allows any extension, but I don't think cp is that common).
  2. If there is a missing normalization of extension, please fix that instead of adding capitalized variants.

FTR, the better solution would be to make this configurable

@github-actions github-actions bot removed the pending:dco PR DCO check is failing, commits need to be signed off label Jun 25, 2024
@ov7a ov7a added the pending:dco PR DCO check is failing, commits need to be signed off label Jun 26, 2024
Copy link
Contributor

While we asked to sign your commits, it has not been done. If you sign your commits, we will consider this pull request again. In the meantime, closing as missing DCO (see the Developer Certificate of Origin GitHub app).

@github-actions github-actions bot closed this Jul 10, 2024
@github-actions github-actions bot added closed:missing-dco Some PR commits are missing a valid signature and removed to-triage pending:dco PR DCO check is failing, commits need to be signed off labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:missing-dco Some PR commits are missing a valid signature from:contributor PR by an external contributor in:native-platform c, cpp, swift and other native languages support, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize .cxx as a valid c++ source file extension
4 participants