Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JUnit tests to use JUnit 5 #60

Open
DPUkyle opened this issue Sep 20, 2024 · 1 comment
Open

Refactor JUnit tests to use JUnit 5 #60

DPUkyle opened this issue Sep 20, 2024 · 1 comment

Comments

@DPUkyle
Copy link
Member

DPUkyle commented Sep 20, 2024

... and remove JUnit 4 dependency

@DPUkyle
Copy link
Member Author

DPUkyle commented Sep 20, 2024

I briefly experimented with this, even removing the JUnit 4 jar entirely. The loss of JUnit 4's @Rule combined with the TemporaryFolder type is a pretty major setback.

Some alternative ideas:

  • Use the documented migration libraries, though this is just a temporary fix
  • Use Spock's @TempDir annotation on a File or Path
  • @TempDir, but applied to a FileSystemFixture. This allows a cool DSL to define folder structure and files, but the file contents must be set in-line. The changes would end up being pretty extensive.

Regardless, I'd want to spend some more time thinking about how to best refactor this code - and if the effort is worth the return. More research is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant