From d52bde990285abf610172483cb0e4c4755f2c6c8 Mon Sep 17 00:00:00 2001 From: James Crosby Date: Thu, 22 Aug 2024 16:04:01 +0100 Subject: [PATCH 1/2] Expose raw flag on media list, so a separate metadata request is not required. --- .../sdk_wireless_camera_control/open_gopro/models/media_list.py | 1 + 1 file changed, 1 insertion(+) diff --git a/demos/python/sdk_wireless_camera_control/open_gopro/models/media_list.py b/demos/python/sdk_wireless_camera_control/open_gopro/models/media_list.py index 3077b226..762045f3 100644 --- a/demos/python/sdk_wireless_camera_control/open_gopro/models/media_list.py +++ b/demos/python/sdk_wireless_camera_control/open_gopro/models/media_list.py @@ -119,6 +119,7 @@ class MediaItem(CustomBaseModel): low_res_video_size: Optional[str] = Field(alias="glrv", default=None) #: Low resolution video size lrv_file_size: Optional[str] = Field(alias="ls", default=None) #: Low resolution file size session_id: Optional[str] = Field(alias="id", default=None) # Media list session identifier + raw: Optional[str] = Field(default=None) #: 1 if photo has raw version, 0 (or omitted) otherwise class GroupedMediaItem(MediaItem): From 46b21c820e8fe4de989970682c538989e9bde655 Mon Sep 17 00:00:00 2001 From: James Crosby Date: Thu, 22 Aug 2024 16:23:37 +0100 Subject: [PATCH 2/2] Add test for raw flag from media list. --- .../sdk_wireless_camera_control/tests/unit/test_models.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/demos/python/sdk_wireless_camera_control/tests/unit/test_models.py b/demos/python/sdk_wireless_camera_control/tests/unit/test_models.py index 4dd2867d..fd0fb1b4 100644 --- a/demos/python/sdk_wireless_camera_control/tests/unit/test_models.py +++ b/demos/python/sdk_wireless_camera_control/tests/unit/test_models.py @@ -116,6 +116,7 @@ "ls": "-1", "s": "25086075", }, + {"n": "GOPR0039.JPG", "cre": "1724339068", "mod": "1724339068", "raw": "1", "s": "783927"}, ], } ], @@ -134,9 +135,10 @@ def test_media_list(): media_list = MediaList(**MEDIA_LIST) assert media_list items = media_list.files - assert len(items) == 12 + assert len(items) == 13 assert len([item for item in items if isinstance(item, GroupedMediaItem)]) == 2 assert media_list.files[0].filename == "100GOPRO/GX010001.MP4" + assert media_list.files[-1].raw == "1" VIDEO_METADATA: Final = {