Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetHardwareInfo HTTP Spec Response Mismatch #581

Closed
mijoost opened this issue Aug 11, 2024 · 2 comments
Closed

GetHardwareInfo HTTP Spec Response Mismatch #581

mijoost opened this issue Aug 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@mijoost
Copy link

mijoost commented Aug 11, 2024

According to the API documentation (both, website and OpenAPI spec) /gopro/camera/info should return an info object.
However, with firmware H23.01.02.20.00 that info object level is omitted (items appear at top level).

curl --request GET --url "http://${CAMERAIPADDRESS}:8080/gopro/camera/info"

{
    "model_number": "62",
    "model_name": "HERO12 Black",
    "firmware_version": "H23.01.02.20.00",
    "serial_number": "C3501xxxxxxxxx",
    "ap_mac_addr": "xxxxxxxxxxxx",
    "ap_ssid": "GP25xxxxxx"
}

@mijoost mijoost added the bug Something isn't working label Aug 11, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Aug 11, 2024
@mijoost mijoost changed the title Bug Description GetHardwareInfo docu mismatch Aug 11, 2024
@tcamise-gpsw
Copy link
Collaborator

Good catch. I'll update the docs.

@tcamise-gpsw tcamise-gpsw self-assigned this Aug 12, 2024
@tcamise-gpsw tcamise-gpsw added documentation Improvements or additions to documentation and removed triage Needs to be reviewed and assigned labels Aug 12, 2024
@tcamise-gpsw tcamise-gpsw changed the title GetHardwareInfo docu mismatch GetHardwareInfo HTTP Spec Response Mismatch Aug 12, 2024
@tcamise-gpsw
Copy link
Collaborator

This has been fixed in the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants