Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Data Types for all integer statuses and settings #538

Closed
sepp89117 opened this issue May 3, 2024 · 4 comments
Closed

Add Data Types for all integer statuses and settings #538

sepp89117 opened this issue May 3, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sepp89117
Copy link

According to your documentation, Status Response 35 returns the available storage space on the SD card in video minutes. However, in practice, it returns the remaining video time in seconds instead of minutes. This inconsistency can lead to confusion for developers integrating with the OpenGoPro API.

Documentation Link: OpenGoPro Documentation

Tested with Hero 10 and 12

@sepp89117 sepp89117 added the bug Something isn't working label May 3, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label May 3, 2024
@tcamise-gpsw
Copy link
Collaborator

Good catch. I'll update it. Really all of the statuses need a review.

@tcamise-gpsw tcamise-gpsw added documentation Improvements or additions to documentation and removed triage Needs to be reviewed and assigned labels May 3, 2024
@tcamise-gpsw tcamise-gpsw self-assigned this May 3, 2024
@sepp89117
Copy link
Author

Hi, since the revision of the documentation I also miss the data types.

@tcamise-gpsw
Copy link
Collaborator

I've update minutes to seconds where applicable.

It is a good point that we should included data types (i.e. int16, etc).
I'll leave this ticket open as an enhancement request to add these.

@tcamise-gpsw tcamise-gpsw changed the title Incorrect Documentation for Status Response 35 Add Data Types for all integer statuses May 9, 2024
@tcamise-gpsw tcamise-gpsw added enhancement New feature or request and removed bug Something isn't working labels May 9, 2024
@tcamise-gpsw tcamise-gpsw changed the title Add Data Types for all integer statuses Add Data Types for all integer statuses and settings Jul 8, 2024
@tcamise-gpsw
Copy link
Collaborator

Integer data types have been added for settings and statuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants