Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photo resolution and timelapse interval settings #533

Closed
sam-dumont opened this issue Apr 24, 2024 · 8 comments
Closed

Add photo resolution and timelapse interval settings #533

sam-dumont opened this issue Apr 24, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sam-dumont
Copy link

As issue 416 has been closed already I'm reopening a new one.

          > So to my understand this is all currently documented. Is there something I'm missing?

I don't think every setting is documented. I'm currently writing a Garmin Edge remote control and when I parse the NotifyPresetStatus reply, there are settings which are missing from the documentation.

For instance, here is what I receive for the photo group ID

         preset_group_array {
           id: PRESET_GROUP_ID_PHOTO
           preset_array {
             id: 65536
             mode: FLAT_MODE_PHOTO
             title_id: PRESET_TITLE_PHOTO
             user_defined: false
             icon: PRESET_ICON_PHOTO
             setting_array {
               id: 122
               value: 101
               is_caption: true
             }
             is_modified: true
           }
           preset_array {
             id: 65537
             mode: FLAT_MODE_LIVE_BURST
             title_id: PRESET_TITLE_LIVE_BURST
             user_defined: false
             icon: PRESET_ICON_LIVE_BURST
             setting_array {
               id: 133
               value: 0
               is_caption: true
             }
             setting_array {
               id: 121
               value: 0
               is_caption: true
             }
             is_modified: false
           }
           preset_array {
             id: 65538
             mode: FLAT_MODE_PHOTO_BURST
             title_id: PRESET_TITLE_BURST
             user_defined: false
             icon: PRESET_ICON_BURST
             setting_array {
               id: 147
               value: 4
               is_caption: true
             }
             setting_array {
               id: 123
               value: 101
               is_caption: true
             }
             is_modified: true
           }
           preset_array {
             id: 65539
             mode: FLAT_MODE_PHOTO_NIGHT
             title_id: PRESET_TITLE_NIGHT
             user_defined: false
             icon: PRESET_ICON_PHOTO_NIGHT
             setting_array {
               id: 19
               value: 0
               is_caption: true
             }
             setting_array {
               id: 122
               value: 101
               is_caption: true
             }
             is_modified: false
           }
           can_add_preset: true
         }

Settings with IDs 133, 147 and 19 are not documented.

Originally posted by @sam-dumont in #416 (comment)

@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Apr 24, 2024
@tcamise-gpsw tcamise-gpsw added question A discussion / question. Not sure if bug or enhancement. and removed triage Needs to be reviewed and assigned labels Apr 24, 2024
@tcamise-gpsw
Copy link
Collaborator

Yes that is correct: not all settings are documented / exposed through Open GoPro.

Some are deprecated, internal, or otherwise do not have reason to be exposed.

@tcamise-gpsw tcamise-gpsw changed the title Documentation for preset setting incomplete Not all settings are exposed through the Open GoPro API Apr 24, 2024
@sam-dumont
Copy link
Author

@tcamise-gpsw Thanks for the reply. Some settings are still missing I think. For instance, I can't find a way to get the interval of a TimeLapse on a GoPro Hero 9. Or an indication of the Photo resolution. It's not a huge issue but it would be nice to show the same settings as what's displayed on the GoPro

@tcamise-gpsw
Copy link
Collaborator

I'm working on a cleanup of the settings right now and will take a look at this after the update is pushed

@tcamise-gpsw tcamise-gpsw self-assigned this May 1, 2024
@tcamise-gpsw
Copy link
Collaborator

Well I've finished the setting cleanup such each setting and each option within a setting is unique.

But this has not solved the issue here. I'll leave this open as an enhancement request to add the requested settings:

  • photo resolution
  • timelapse interval

There are many internal settings that are not being publicly exposed for no valid reason. We need to go through and add these.

@tcamise-gpsw tcamise-gpsw added documentation Improvements or additions to documentation enhancement New feature or request and removed question A discussion / question. Not sure if bug or enhancement. labels May 9, 2024
@tcamise-gpsw tcamise-gpsw changed the title Not all settings are exposed through the Open GoPro API Add photo resolution and timelapse interval settings May 9, 2024
@sfoley-gpqa
Copy link
Collaborator

@sam-dumont

That is a really cool app idea. Do you have any plans on developing a version with support for Garmin Fenix 6? I'm wearing one now and would really like that!

@sam-dumont
Copy link
Author

@sam-dumont

That is a really cool app idea. Do you have any plans on developing a version with support for Garmin Fenix 6? I'm wearing one now and would really like that!

Unfortunately the interactions possible when using a watch are very limited. The only way to make it work would be to tie the recording to start/stop activity and lap button. Not ideal but could be doable. Also, Fenix 6 will never be supported because those devices lack the proper APIs (they can't deal with secure BLE).

I'm already very slow to add features for Edge devices, and GoPro 12 are very tough to handle because they behave differently in terms of BLE advertising and pairing so I have a lot to finish first. Watch support is not going to be done very soon... Sorry!

@sfoley-gpqa
Copy link
Collaborator

@sam-dumont
That is a really cool app idea. Do you have any plans on developing a version with support for Garmin Fenix 6? I'm wearing one now and would really like that!

Unfortunately the interactions possible when using a watch are very limited. The only way to make it work would be to tie the recording to start/stop activity and lap button. Not ideal but could be doable. Also, Fenix 6 will never be supported because those devices lack the proper APIs (they can't deal with secure BLE).

I'm already very slow to add features for Edge devices, and GoPro 12 are very tough to handle because they behave differently in terms of BLE advertising and pairing so I have a lot to finish first. Watch support is not going to be done very soon... Sorry!

That's alright. The Edge project is still very cool!

@tcamise-gpsw
Copy link
Collaborator

Closing this since it has been implemented via:

The following settings have been documented:

There is no photo resolution setting as it is not configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants