Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmcli version check fails on RHEL based systems (Fedora) #481

Closed
epheo opened this issue Feb 14, 2024 · 1 comment · Fixed by #482
Closed

nmcli version check fails on RHEL based systems (Fedora) #481

epheo opened this issue Feb 14, 2024 · 1 comment · Fixed by #482
Labels
bug Something isn't working triage Needs to be reviewed and assigned

Comments

@epheo
Copy link
Contributor

epheo commented Feb 14, 2024

Component
Python SDK

Describe the bug
nmcli version check fails on RHEL based systems (Fedora)

To Reproduce
Use gopro-wifi on a RHEL based system.

Expected behavior
Version check to pass

Error message
InvalidVersion: Invalid version: '1.44.2-1.fc39'

Additional context
Opening this ticket to match my pull request.

@epheo epheo added the bug Something isn't working label Feb 14, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Feb 14, 2024
@epheo
Copy link
Contributor Author

epheo commented Apr 4, 2024

Arch Linux is also impacted as it returns version number as follow:
'1.44.2-1'

Therefore the above mentioned patch isn't applicable for Arch Linux systems.

I would suggest to delete the isalpha() condition and always strip version numbers on - on the above pull request which wouldn't change the original behavior on Ubuntu Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs to be reviewed and assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant