Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable narrow lens mode for streaming #475

Closed
CraigChisholm opened this issue Jan 24, 2024 · 5 comments
Closed

Enable narrow lens mode for streaming #475

CraigChisholm opened this issue Jan 24, 2024 · 5 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@CraigChisholm
Copy link

Is your feature request related to a problem or use case? Please describe.
When using the GoPro Quik app on GoPro Hero 10 Black it is possible to start streaming with any of four lens modes

  • Narrow
  • Linear
  • Wide
  • Superview

Using the open-gopro module in Python, the narrow view is not available as an option in EnumLens.

Describe the solution you'd like
Add LENS_NARROW to EnumLens.

Describe alternatives you've considered
I've tried modifying the source code but haven't yet found the correct file. I know that the value corresponding to NARROW_LENS should be 2.

Additional context
None

@CraigChisholm CraigChisholm added the enhancement New feature or request label Jan 24, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Jan 24, 2024
@tcamise-gpsw tcamise-gpsw added bug Something isn't working demos Relating to demos and removed enhancement New feature or request triage Needs to be reviewed and assigned labels Apr 11, 2024
@tcamise-gpsw tcamise-gpsw self-assigned this Apr 11, 2024
@tcamise-gpsw
Copy link
Collaborator

Yeah this looks like a bug. I'm working on updating the protobuf files to add it back in, then I'll regenerate the Python code.

@tcamise-gpsw
Copy link
Collaborator

Actually it's possible that this option was broken. I just tested livestreaming in Quik to Hero 10 via Android and iOS and I do not see an option to even set then lens. Where are you seeing this?

@tcamise-gpsw tcamise-gpsw added question A discussion / question. Not sure if bug or enhancement. feedback requested Further information is requested and removed question A discussion / question. Not sure if bug or enhancement. labels Apr 11, 2024
@tcamise-gpsw
Copy link
Collaborator

It turns out that I had already discovered this in the past and have a bug open to fix the documentation: #374

So I will close this as duplicate and update the documentation in that linked ticket.

@tcamise-gpsw tcamise-gpsw closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@tcamise-gpsw tcamise-gpsw added duplicate This issue or pull request already exists and removed feedback requested Further information is requested demos Relating to demos labels Apr 12, 2024
@CraigChisholm
Copy link
Author

I don't think this duplication mark is correct. I am using a Hero 10 Black and I can set the field of view to Linear, Wide, and Superview before starting the stream and I do see the obvious change in the image. My problem is that when I am using the camera touch screen it has an additional Narrow mode which is not available in the Protobuf commands. Which is different to the bug #374 where certain cameras do not support setting the field of view.

@tcamise-gpsw
Copy link
Collaborator

tcamise-gpsw commented Apr 16, 2024

From an official usage perspective: the only lenses that are supported for livestreaming are those dynamically reported from the live_stream_lens_supported_array in NotifyLiveStreamStatus). That is, the only way to configure the lens for livestream is to use one of these reported options and set the lens parameter of RequestSetLiveStreamMode.

Hero 10 Black does not set this live_stream_lens_supported_array so this parameter is therefore not configurable.

The UI Narrow mode that you are referring to is the Lens setting for one of the Photo, Video, or Timelapse modes Settings. This has no relevance on livestreaming and would get overridden by the livestreaming parameter if it did exist. Since this is not configurable on Hero 10 Black, it gets overridden by the default.

This is the same reason the Quik App does not provide a lens option for livestreaming with Hero 10 Black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
Status: Done
Development

No branches or pull requests

2 participants