Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper HTTP method types #470

Closed
axeljaeger opened this issue Jan 12, 2024 · 1 comment
Closed

Use proper HTTP method types #470

axeljaeger opened this issue Jan 12, 2024 · 1 comment
Labels
enhancement New feature or request requires firmware changes Requires Camera Firmware Changes wontfix This will not be worked on

Comments

@axeljaeger
Copy link

Component

  • Specs (HTTP)

Describe the bug
Currently, the GoPro HTTP API only uses HTTP GET and POST Requests. According to https://www.w3schools.com/tags/ref_httpmethods.asp
"GET requests are only used to request data (not modify)"

Currently, whether a method is using GET or POST seems a bit random and DELETE is not used at all.

Expected behavior

PS: I am so glad that you guys now use a proper API description. I was about to create my own:

@axeljaeger axeljaeger added the bug Something isn't working label Jan 12, 2024
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Jan 12, 2024
@tcamise-gpsw
Copy link
Collaborator

Yes this would be nice and something I have been pushing for for new commands. But there is definitely not going to be a major rewrite of the API any time soon.

@tcamise-gpsw tcamise-gpsw closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@tcamise-gpsw tcamise-gpsw added enhancement New feature or request wontfix This will not be worked on requires firmware changes Requires Camera Firmware Changes and removed bug Something isn't working triage Needs to be reviewed and assigned labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request requires firmware changes Requires Camera Firmware Changes wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants