Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra data returned by BLE Get Hardware Info (0x3c) command response (after MAC which is the last documented field) #454

Closed
pokmis opened this issue Dec 11, 2023 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@pokmis
Copy link

pokmis commented Dec 11, 2023

Component
What is the bug in?

  • Specs (BLE , HTTP)

Describe the bug
The response to the 'Get Hardware Info' command includes additional data no documented in the specs.

example response:
20:60:3c:00:04:00:00:00:37:0b:48:45:52:4f:39:20:42:6c:61:63: <- initial response
80:6b:04:30:78:30:35:0f:48:44:39:2e:30:31:2e:30:31:2e:36:30: <- continuation
81:2e:30:30:0e:43:33:34:34:31:33:32:34:38:30:34:37:39:32:0b: <- continuation
82:48:45:52:4f:39:20:42:6c:61:63:6b:0c:64:36:33:32:36:30:62: <- continuation
83:35:35:31:39:35:01:00:01:01:01:00:07:5b:22:62:6c:65:22:5d: <- continuation (extra starts here)
84:01:01: <- continuation (extra continues here)

This decodes as:
commandSentSuccessfully:0
modelNumber: 55
lengthOfModelId: 11
modelId: "HERO9 Black"
boardType:"0x05"
firmwareVersion:"HD9.01.01.60.00"
serialNumber: "C3441324804792"
ssid: "HERO9 Black"
Mac: "d63260b55195"

The final sequence "01:00:01:01:01:00:07:5b:22:62:6c:65:22:5d:84:01:01" are all additional bytes not included in the documentation: https://gopro.github.io/OpenGoPro/ble_2_0#get-hardware-info

Any idea how these bytes should be interpreted?

To Reproduce
Steps to reproduce the behavior:
Send BLE command data [0x01, 0x3c] to GP-0072 and await the response packets on GP-0073

Expected behavior
I expected the response data for Get Hardware Info to end with the MAC address

Screenshots
If applicable, add screenshots to help explain your problem.

Hardware

  • Camera: Hero9,.
  • Smartphone iPhone 12
@pokmis pokmis added the bug Something isn't working label Dec 11, 2023
@github-actions github-actions bot added the triage Needs to be reviewed and assigned label Dec 11, 2023
@tcamise-gpsw tcamise-gpsw added requires firmware changes Requires Camera Firmware Changes and removed triage Needs to be reviewed and assigned labels Dec 11, 2023
@tcamise-gpsw
Copy link
Collaborator

Hello. I am able to reproduce this even on the latest Hero 12 firmware. This extra data should not be getting sent from the camera so I will open a bug to fix this internally.

For now, you can safely ignore the extra data.

@tcamise-gpsw tcamise-gpsw self-assigned this Dec 11, 2023
@tcamise-gpsw
Copy link
Collaborator

It turns out there is no plan to change the behavior here. Instead I have updated the documentation to note these "reserved" bytes.

@tcamise-gpsw tcamise-gpsw added documentation Improvements or additions to documentation and removed requires firmware changes Requires Camera Firmware Changes labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants