Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor local task cache to LRU implement. #254

Open
IRONICBo opened this issue Mar 8, 2024 · 1 comment
Open

feat: refactor local task cache to LRU implement. #254

IRONICBo opened this issue Mar 8, 2024 · 1 comment

Comments

@IRONICBo
Copy link
Collaborator

IRONICBo commented Mar 8, 2024

golang-lru seems to have implemented some concurrency-safe caching policies that can replace our local existing implementation logic internal/core/task.go to support better cache management.

For now it's enough to only consider standalone cache management, I've also given some bench processing in test, and also need to consider a performance comparison between the two implementations.

If there is a better solution you can comment below

Reference: https://github.com/hashicorp/golang-lru

@IRONICBo
Copy link
Collaborator Author

IRONICBo commented Mar 8, 2024

/assign @huangsihao7 @IRONICBo

@IRONICBo IRONICBo changed the title Feat: refactor local task cache to LRU implement. feat: refactor local task cache to LRU implement. Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant