sadah / 課題1 #8
Open
sadah / 課題1 #8
+314
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Jul 21, 2020
| tarExt = "." + tarExt | ||
| } | ||
|
|
||
| func run() (err error) { |
There was a problem hiding this comment.
名前付き戻り値はドキュメンテーションまたはdefer内で戻り値を変更したい場合以外は基本的には用いないほうが良いです。
tenntenn
reviewed
Jul 21, 2020
| if err != nil { | ||
| return err | ||
| } | ||
| if filepath.Ext(path) == srcExt { |
There was a problem hiding this comment.
ディレクトリかファイルかのチェックもあってもいいかもしれないです。
拡張子がついてるので微妙ですが。
tenntenn
reviewed
Jul 21, 2020
|
|
||
| var ( | ||
| // SupportedExts is a list of supported extensions | ||
| SupportedExts exts = []string{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題1: 画像変換コマンドを作ろう のPRになります。
詳細は README に記載しています。
レビューよろしくお願いいたします。