InoAyaka / 課題1 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenntenn
reviewed
Jul 8, 2020
|
|
||
| //addFileName どのファイルでエラーになったか分かるようにerrにファイル名を付加して返します。 | ||
| func addFileName(err error, f string) error { | ||
| err = fmt.Errorf("%v\nerrFile : %s", err, f) |
There was a problem hiding this comment.
関数にせず、fmt.Errorf("%w: %s", out.Name())のようにラップした方がよいです。
https://golang.org/pkg/fmt/#Errorf
ログとかのことを考えるとエラーメッセージは改行入れないほうがいいです。
tenntenn
reviewed
Jul 8, 2020
| os.Exit(1) | ||
| } | ||
|
|
||
| convert() |
tenntenn
reviewed
Jul 8, 2020
| //Args ImageConverter()を使う際に指定が必要となる引数 | ||
| type Args struct { | ||
| FilePath string //変換対象となるファイル名 | ||
| Bf string //変換前 画像形式 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題1のPRになります。
レビューいただけると幸いです。
詳細は、README.mdをご確認ください。