Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsuchinaga / 課題1 #3

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

tsuchinaga / 課題1 #3

wants to merge 13 commits into from

Commits on Jul 6, 2020

  1. 課題1の実装

    @tsuchinaga
    tsuchinaga committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    2c0ce8a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. intellij関連のファイルを除外

    @tsuchinaga
    tsuchinaga committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ef47347 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. 有効なファイルタイプをmapで管理することでシンプルにするリファクタリング

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    fffa8c5 View commit details
    Browse the repository at this point in the history

  2. go.sum追加し忘れてた

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0a52dfb View commit details
    Browse the repository at this point in the history

  3. ディレクトリかのチェックをos.Statを使うよう修正

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6a2ec42 View commit details
    Browse the repository at this point in the history

  4. パッケージ名、実行関数の名前を変更し、意味の重複を回避するよう修正

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    943bc4b View commit details
    Browse the repository at this point in the history

  5. goimportsでimport文を整理

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    bcbc6c4 View commit details
    Browse the repository at this point in the history

  6. log.Fatal系を呼んでいたところをPrint系+Exitに変更

    @tsuchinaga
    tsuchinaga committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    6b17c74 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. とりあえず全てのエラーを上に返していくよう変更

    @tsuchinaga
    tsuchinaga committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6dae5bb View commit details
    Browse the repository at this point in the history

  2. 書き込みファイルのエラーを返すために名前付きの戻り値を使うよう変更

    @tsuchinaga
    tsuchinaga committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    9c8786d View commit details
    Browse the repository at this point in the history

  3. エラーをまとめて一か所で処理せず、エラー発生個所で処理するよう変更

    @tsuchinaga
    tsuchinaga committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d17fd46 View commit details
    Browse the repository at this point in the history

  4. エラーを握りつぶさず、エラーとして返すよう変更

    @tsuchinaga
    tsuchinaga committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    872cef7 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. imgconvパッケージはchan errorを返すようにし、mainがエラーをハンドリングできるようにする

    @tsuchinaga
    tsuchinaga committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    37228b3 View commit details
    Browse the repository at this point in the history