Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manifest V3] Broken error handling in background script #263

Open
Pharb opened this issue Oct 12, 2024 · 0 comments
Open

[Manifest V3] Broken error handling in background script #263

Pharb opened this issue Oct 12, 2024 · 0 comments
Labels

Comments

@Pharb
Copy link
Member

Pharb commented Oct 12, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any login page
  2. Try to fill in password from gopassbridge
  3. Use wrong GPG pin (or other error case preventing successful password retrieval)
  4. See error in dev tools Uncaught (in promise) Error: browser.extension.getViews is not a function from processMessageAndCatch

Expected behavior
Error can be shown in notification if popup is closed.

Screenshots
Screenshot 2024-10-12 at 16 09 32

System (please complete the following information):

  • OS: macOS 14.7
  • Browser: Chrome 129.0.6668.101
  • Gopassbridge version: 2.0.0
  • gopass --version: gopass 1.15.14 go1.22.5 darwin arm64
  • gopass-jsonapi --version: gopass-jsonapi version 1.15.14

Issues with installation

  • Did you try restarting your gpg-agent and browser (e.g. killall gpg-agent)? YES
  • Did you reconfigure gopass-jsonapi with the current version (e.g. gopass-jsonapi configure)? NO

Did the problem change with these steps (e.g. different error message, now it works)?

YES, this usually fixes the problem, but the error handling is still incompatible running with Manifest V3 APIs.

@Pharb Pharb changed the title [Manifest V3] Broken error handling of in background script [Manifest V3] Broken error handling in background script Oct 12, 2024
@Pharb Pharb removed the unsure label Oct 12, 2024
@Pharb Pharb mentioned this issue Oct 12, 2024
Pharb added a commit that referenced this issue Oct 12, 2024
proper solution to be implemented with #263

Signed-off-by: Patrick Harböck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant