Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add administrativeArea, postalCode to addressverification when using USPS CASS #526

Open
morgandenning opened this issue Jun 28, 2024 · 0 comments
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@morgandenning
Copy link

morgandenning commented Jun 28, 2024

Thanks for stopping by to let us know something could be better!


PLEASE READ

If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.

Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.

If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.

Check for answers on StackOverflow with the google-maps tag.


Is your feature request related to a problem? Please describe.
When using the enableUspsCass argument, we are noticing inconsistent responses with administrativeArea and postalCode being included in the addressLines list. the addressvalidation method should allow additional properties for these values in the arguments, to match what can be sent to the API (see: https://developers.google.com/maps/documentation/address-validation/requests-validate-address#enable-cass)

Describe the solution you'd like
Modify the above method to support two additional arguments, such as

def addressvalidation(client, addressLines, regionCode=None , locality=None, enableUspsCass=None, administrativeArea=None, postalCode=None):

I have forked this repository and made the desired changes, if this solution is acceptable.

Describe alternatives you've considered
Not including enableUspsCass as an option, however this package could be modified to support both.

Additional context
Add any other context or screenshots about the feature request here.

@morgandenning morgandenning added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant