Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ufo2ft.filters.transformations change the advance width? #490

Closed
simoncozens opened this issue Mar 24, 2021 · 5 comments · Fixed by #515
Closed

Should ufo2ft.filters.transformations change the advance width? #490

simoncozens opened this issue Mar 24, 2021 · 5 comments · Fixed by #515

Comments

@simoncozens
Copy link
Contributor

I feel like it should change the advance widths when the glyphs are scaled, but currently it doesn't. Happy to write a PR if we think it should.
@anthrotype
Copy link
Member

the filter was originally added to mimic the behavior of Glyphs.app Transformations filter. What does it do about advances?

@simoncozens
Copy link
Contributor Author

It scales them.

@anthrotype
Copy link
Member

anthrotype commented Mar 24, 2021 •
edited
Loading

does it do automatically whenever there's a scale, or are they treated separately?

@simoncozens
Copy link
Contributor Author

No, automatically when there's a scale set.

@moyogo
Copy link
Collaborator

moyogo commented Mar 24, 2021

A PR would be nice :-).

This reminds me, #238 needs to be rebased so ufo2ft's filter can also handle metrics independently.

@simoncozens simoncozens mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform advance width (and height) when scaling simoncozens/ufo2ft
3 participants
@simoncozens @moyogo @anthrotype