Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing git tags #193

Open
alerque opened this issue Apr 14, 2020 · 13 comments
Open

Missing git tags #193

alerque opened this issue Apr 14, 2020 · 13 comments
Assignees

Comments

@alerque
Copy link
Contributor

alerque commented Apr 14, 2020

PyPi version is at 0.3.7, the latest git tag in this repo is 0.1.0. We're missing a few tags in there...

@felipesanches
Copy link
Member

thanks for the reminder! We'll try to adopt the practice of tagging releases just like I regularly do with FontBakery. ;-D

@felipesanches
Copy link
Member

I wonder how hard would it be to find out the correct git commits for each of our past releases. I may try doing so...

@alerque
Copy link
Contributor Author

alerque commented Apr 14, 2020

It shouldn't be too hard I wouldn't think if the release procedure didn't vary too much between versions. It would be nice to backfill tags ;-)

@alerque
Copy link
Contributor Author

alerque commented Oct 29, 2020

Just a gentle reminder, since I posted this issue there have been 14 new releases (0.3.8–0.4.5) to PyPi with no matching tags in the Git repository.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 29, 2020

I'll start adding release going forward and I'll try and include terse release notes as well.

This repo is in dire need of a cleanup, hopefully I can start making improvements to it over the course of this year. It was originally a dumping ground for write once and forget scripts. Since they're used daily, we should improve them.

@chrissimpkins
Copy link
Member

chrissimpkins commented Oct 29, 2020

If helpful, there is a very simple approach to auto GH release + PyPI push via GH Actions. You push a git tag and you are done. Requires the PyPI project owner to add their PyPI username/pw in this repo's "Secrets" config panel.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 29, 2020

Thanks Chris, I'll use this going forward.

@chrissimpkins
Copy link
Member

I am happy to PR the config in if you'd like. Let me know if I can help.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 29, 2020

That would be great. Thanks Chris!

@chrissimpkins
Copy link
Member

#265

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 12, 2020

I've just pushed v0.5.0 which uses the new Github action, https://github.com/googlefonts/gftools/releases/tag/v0.5.0. Works perfectly.

@m4rc1e m4rc1e closed this as completed Nov 12, 2020
@m4rc1e m4rc1e reopened this Nov 12, 2020
@chrissimpkins
Copy link
Member

Fantastic!

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 12, 2020

I'll add the missing tags soonish. There's probably a scriptable way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants