[POC] add client side logging #3403
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g needs more work.
blakeli0
reviewed
Dec 3, 2024
gax-java/gax/src/main/java/com/google/api/gax/logging/LoggingUtils.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Dec 3, 2024
| @Override | ||
| public void start(Listener<RespT> responseListener, Metadata headers) { | ||
| if (logger.isInfoEnabled()) { | ||
| String requestId = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
I think requestId is for debugging purpose for now and would be removed later?
There was a problem hiding this comment.
Yes for now. Later when we also log in tracer, we may need some requestID to track (not this one).
blakeli0
reviewed
Dec 3, 2024
gax-java/gax/src/main/java/com/google/api/gax/logging/JsonContextMapHandler.java
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Dec 3, 2024
gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcLoggingInterceptor.java
Outdated
Show resolved
Hide resolved
…g entries, add request id to track.
…ing interceptors.
product-auto-label
bot
added
size: xl
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - test failures still expected.
Will update description when ready