Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update action version through shell script #3397

Merged
merged 5 commits into from
Dec 3, 2024
Merged

chore: update action version through shell script #3397

merged 5 commits into from
Dec 3, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Nov 25, 2024 •
edited
Loading

In this PR:

  • Update composite action version in update_generation_config.sh so that the action version is updated in the same PR with image update.
  • Do not update the action version through renovate.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 25, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 2, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review December 2, 2024 16:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

diegomarquezp
diegomarquezp approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@diegomarquezp diegomarquezp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeWang1127 JoeWang1127 merged commit 1baedfe into main Dec 3, 2024
49 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/update-action-ver branch December 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeWang1127 @diegomarquezp