Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-please-action ignoring bootstrap sha and last release #1052

Closed
mrcjkb opened this issue Nov 11, 2024 · 2 comments
Closed

release-please-action ignoring bootstrap sha and last release #1052

mrcjkb opened this issue Nov 11, 2024 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mrcjkb
Copy link

mrcjkb commented Nov 11, 2024

Hey 👋

I had the release-please action configured to bootstrap at a given commit (via a release-please-config.json.
It all worked fine, until a few days ago, the workflow runs started adding the entire commit history to the latest release (ignoring the bootstrap sha and the last release), resulting in this PR generated by this workflow run.

I have tried

  • Setting the bootstrap sha to a more recent commit
  • Deleting the release-please-config.json (as the docs say it is only needed for the first run)
@mrcjkb mrcjkb added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 11, 2024
@mrcjkb
Copy link
Author

mrcjkb commented Nov 12, 2024

Looks like it all started with this failed run, which was triggered by merging a release PR:

❯ pull request title pattern: undefined
✔ Looking for open release pull requests
✔ found 0 open release pull requests.
✔ Looking for snoozed release pull requests
✔ found 0 snoozed release pull requests.
❯ Fetching CHANGELOG.md from branch master
❯ Fetching version.txt from branch master
⚠ file version.txt did not exist
❯ Fetching .release-please-manifest.json from branch master
⚠ file .release-please-manifest.json did not exist
✔ Starting GitHub PR workflow...
✔ Successfully found branch HEAD sha "7a8665bdf891ec00277704fd4a5b719587ca9082".
✔ Successfully created branch at https://api.github.com/repos/mrcjkb/rustaceanvim/git/refs/heads/release-please--branches--master
✔ Got the latest commit tree
✔ Successfully created a tree with the desired changes with SHA 81ce15e967f99c3636dfd168e9c961e9414d0fec
✔ Successfully created commit. See commit at https://api.github.com/repos/mrcjkb/rustaceanvim/git/commits/c140bbaaba678b803b8f186bce2248fd889be217
✔ Updating reference heads/release-please--branches--master to c140bbaaba678b803b8f186bce2248fd889be217
✔ Successfully updated reference release-please--branches--master to c140bbaaba678b803b8f186bce2248fd889be217
Error: release-please failed: Server Error

@mrcjkb
Copy link
Author

mrcjkb commented Nov 12, 2024

Manually pushing the tag and creating a release for the failed run has fixed the issue.

@mrcjkb mrcjkb closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant