Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples tests for samples/beam fail with python 3.7 and newer versions of apache-beam and google-cloud-bigtable #904

Open
parthea opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@parthea
Copy link
Contributor

parthea commented Dec 14, 2023

See build log here.

Using apache-beam==2.52.0 and google-cloud-bigtable==2.21.0 samples test fail. Reverting back to apache-beam===2.46.0 and google-cloud-bigtable===2.17.0 for python 3.7 only allows tests to pass.

------------------------------------------------------------
- testing samples/beam
------------------------------------------------------------
nox > Running session py-3.7
nox > Creating virtual environment (virtualenv) using python3.7 in .nox/py-3-7
nox > python -m pip install -r requirements.txt
nox > python -m pip install -r requirements-test.txt
nox > pytest --junitxml=sponge_log.xml
============================= test session starts ==============================
platform linux -- Python 3.7.17, pytest-7.4.3, pluggy-1.2.0
rootdir: /workspace
collected 1 item

hello_world_write_test.py F                                              [100%]

=================================== FAILURES ===================================
____________________________ test_hello_world_write ____________________________

table_id = 'mobile-time-series-3fbd0741-3084-4f'

    def test_hello_world_write(table_id):
        hello_world_write.run(
            [
                "--bigtable-project=%s" % PROJECT,
                "--bigtable-instance=%s" % BIGTABLE_INSTANCE,
                "--bigtable-table=%s" % table_id,
            ]
        )
    
        client = bigtable.Client(project=PROJECT, admin=True)
        instance = client.instance(BIGTABLE_INSTANCE)
        table = instance.table(table_id)
    
        rows = table.read_rows()
        count = 0
        for _ in rows:
            count += 1
>       assert count == 2
E       assert 0 == 2
@parthea parthea added type: docs Improvement to the documentation for an API. samples Issues that are directly related to samples. labels Dec 14, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Dec 14, 2023
parthea added a commit to renovate-bot/python-bigtable that referenced this issue Dec 14, 2023
@billyjacobson
Copy link
Contributor

Can the build be reran? This code seems pretty simple, so I wonder if there was just some flakiness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

No branches or pull requests

2 participants