Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase minimum version of google-cloud-core to 1.6.0 #509

Closed
tswast opened this issue Feb 4, 2021 · 1 comment · Fixed by #1487
Closed

increase minimum version of google-cloud-core to 1.6.0 #509

tswast opened this issue Feb 4, 2021 · 1 comment · Fixed by #1487
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Feb 4, 2021

Once enough time has passed to give people time to upgrade (TBD how long that is), we should increase the minimum version and clean up and logic that switches based on package version that was added in #492.
@tswast tswast added status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like. labels Feb 4, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 5, 2021
@plamut plamut mentioned this issue Feb 9, 2021
Closed
@tswast
Copy link
Contributor Author

tswast commented Mar 29, 2021

I did a bit more research on how the Python data science community supports core library versions. They have a rolling 2-year window. googleapis/python-bigquery-pandas#357

I still want to do some analysis of how quickly people upgrade core libraries in practice to see if 2-years is the right window. (Hopefully people are upgrading much more frequently than this)

@chalmerlowe chalmerlowe added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Nov 10, 2022
@tswast tswast self-assigned this Feb 7, 2023
@tswast tswast mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: annotate optional integer parameters with optional type googleapis/python-bigquery
2 participants
@tswast @chalmerlowe