Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid blocking in download thread when using BQ Storage API #2034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: avoid blocking in download thread when using BQ Storage API #2034

wants to merge 2 commits into from

Conversation

kien-truong
Copy link
Contributor

This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.

Fixes #2032 🦕

@kien-truong kien-truong requested review from a team as code owners September 28, 2024 03:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 28, 2024
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@Linchin Linchin self-assigned this Oct 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2024
@Linchin Linchin removed their assignment Oct 8, 2024
@kien-truong kien-truong force-pushed the fix-bq-storage-client-deadlock branch from 256b0f7 to 3f8bd10 Compare October 10, 2024 15:12
@kien-truong
Copy link
Contributor Author

Just dropping by to see if there's any concerns about this PR.

@kien-truong
fix: avoid blocking in download thread when using BQ Storage API
8eebb9d 
This prevents a deadlock between the main thead and download threads
when the threadpool is shutdown prematurely.
@kien-truong kien-truong force-pushed the fix-bq-storage-client-deadlock branch from d3f2f1e to 8eebb9d Compare November 3, 2024 03:37
@kien-truong kien-truong mentioned this pull request Nov 16, 2024
Open
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@chalmerlowe
Copy link
Collaborator

I took a quick look.
Gonna run our CI/CD checks on this.
My first thought is that because we are adding a couple code paths coverage is likely to fail.
Also curious why the pragma for queue.full: we recently got bitten by having a code branch that was not tested and I am hesitant about adding more such paths to the code base without understanding for myself why it is necessary/desireable.

@kien-truong
Copy link
Contributor Author

The queue.Full code path is hard to test because it's non-deterministic: the queue can be full or not depending on the timing of consumers and producers.

So, I just put a pragma there to ignore the coverage, similar to the existing code a few lines below.

python-bigquery/google/cloud/bigquery/_pandas_helpers.py

Line 968 in aaec3ce

except queue.Empty: # pragma: NO COVER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/api-bigquery

At least 1 approving review is required to merge this pull request.

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock due to race condition in download thread when using Bigquery Storage API
5 participants
@kien-truong @chalmerlowe @hongalex @Linchin @yoshi-kokoro