Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toplevel "proto' folder exposed #486

Open
thehesiod opened this issue Sep 10, 2024 · 0 comments
Open

toplevel "proto' folder exposed #486

thehesiod opened this issue Sep 10, 2024 · 0 comments
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@thehesiod
Copy link

this module exposes a top-level "proto" folder which can conflict with any projects which have a top-level "proto" folder used as imports. All top-level folders exposed by this project should be prefixed / namespaced.

 ls '~/.local/share/virtualenvs/commodities-uyI3VCa_/lib/python3.11/site-packages/proto'
__init__.py		_file_info.py		datetime_helpers.py	fields.py		message.py		primitives.py		version.py
__pycache__		_package_info.py	enums.py		marshal			modules.py		utils.py

proto-plus version 1.24.0

@thehesiod thehesiod added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 10, 2024
@parthea parthea added the next major: breaking change this is a change that we should wait to bundle into the next major version label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants