Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing Flaky test #2244

Closed
ehsannas opened this issue Dec 3, 2024 · 0 comments · Fixed by #2245
Closed

Tracing Flaky test #2244

ehsannas opened this issue Dec 3, 2024 · 0 comments · Fixed by #2245
Assignees
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ehsannas
Copy link
Contributor

ehsannas commented Dec 3, 2024

This client-side tracing test

it('document reference update()', async () => {
await runFirestoreOperationInRootSpan(() =>
firestore.collection('foo').doc('bar').update('foo', 'bar2')
);
await waitForCompletedSpans(3);
expectSpanHierarchy(
SPAN_NAME_TEST_ROOT,
SPAN_NAME_DOC_REF_UPDATE,
SPAN_NAME_BATCH_COMMIT
);
});

assumes that the foo/bar document exists -- which it shouldn't. It sometimes passes because most often the previous test creates that document:

it('document reference set()', async () => {
await runFirestoreOperationInRootSpan(() =>
firestore.collection('foo').doc('bar').set({foo: 'bar'})
);

I'll fix this test.

@ehsannas ehsannas added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 3, 2024
@ehsannas ehsannas self-assigned this Dec 3, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Dec 3, 2024
ehsannas added a commit that referenced this issue Dec 3, 2024
ehsannas added a commit that referenced this issue Dec 3, 2024
MarkDuckworth pushed a commit that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant