From cc622fc3c18bc675def69bb98b9bea1b80b68edd Mon Sep 17 00:00:00 2001 From: Mila <107142260+milaGGL@users.noreply.github.com> Date: Thu, 17 Aug 2023 15:44:31 -0400 Subject: [PATCH 1/4] Add warning message when passing DcoumentReference in cursor (#1883) --- dev/src/reference.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dev/src/reference.ts b/dev/src/reference.ts index f268df88e..f2ea86229 100644 --- a/dev/src/reference.ts +++ b/dev/src/reference.ts @@ -1845,6 +1845,15 @@ export class Query implements firestore.Query { return this._queryOptions.fieldOrders; } + // TODO(b/296435819): Remove this warning message. + if (cursorValuesOrDocumentSnapshot[0] instanceof DocumentReference) { + // eslint-disable-next-line no-console + console.warn( + `Warning: Passing DocumentReference into a cursor without orderBy clause is not an intended + behavior. Please use DocumentSnapshot or add an explicit orderBy on document key field.` + ); + } + const fieldOrders = this._queryOptions.fieldOrders.slice(); // If no explicit ordering is specified, use the first inequality to From fba4949be5be8b26720f0fefcf176e549829e382 Mon Sep 17 00:00:00 2001 From: Mend Renovate Date: Thu, 17 Aug 2023 23:29:58 +0200 Subject: [PATCH 2/4] chore(deps): update dependency jsdoc-fresh to v3 (#1880) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7d6b0678d..00ce0143a 100644 --- a/package.json +++ b/package.json @@ -82,7 +82,7 @@ "extend": "^3.0.2", "gts": "^3.1.0", "jsdoc": "^4.0.0", - "jsdoc-fresh": "^2.0.0", + "jsdoc-fresh": "^3.0.0", "jsdoc-region-tag": "^2.0.0", "length-prefixed-json-stream": "^1.0.1", "linkinator": "^5.0.0", From d2b97c4e041ca6f3245b942540e793d429f8e5c5 Mon Sep 17 00:00:00 2001 From: Mend Renovate Date: Mon, 28 Aug 2023 19:49:26 +0200 Subject: [PATCH 3/4] chore(deps): update dependency jsdoc-region-tag to v3 (#1881) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 00ce0143a..9a92d8f42 100644 --- a/package.json +++ b/package.json @@ -83,7 +83,7 @@ "gts": "^3.1.0", "jsdoc": "^4.0.0", "jsdoc-fresh": "^3.0.0", - "jsdoc-region-tag": "^2.0.0", + "jsdoc-region-tag": "^3.0.0", "length-prefixed-json-stream": "^1.0.1", "linkinator": "^5.0.0", "mocha": "^9.2.2", From f964634bc8ef962ff69d61507e86b766f791b9a6 Mon Sep 17 00:00:00 2001 From: Dima Grossman Date: Thu, 31 Aug 2023 01:58:32 +0300 Subject: [PATCH 4/4] chore: upgrade protobufjs dependency (#1889) Co-authored-by: Mark Duckworth <1124037+MarkDuckworth@users.noreply.github.com> --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 9a92d8f42..693b18888 100644 --- a/package.json +++ b/package.json @@ -62,7 +62,7 @@ "fast-deep-equal": "^3.1.1", "functional-red-black-tree": "^1.0.1", "google-gax": "^3.5.7", - "protobufjs": "^7.0.0" + "protobufjs": "^7.2.5" }, "devDependencies": { "@types/assert": "^1.4.0", @@ -87,7 +87,7 @@ "length-prefixed-json-stream": "^1.0.1", "linkinator": "^5.0.0", "mocha": "^9.2.2", - "protobufjs-cli": "^1.0.0", + "protobufjs-cli": "^1.1.2", "proxyquire": "^2.1.3", "sinon": "^15.0.0", "through2": "^4.0.0",