Drop Animal Sniffer in favor of building with a newer JDK using the release flag #1757
Labels
api: storage
Issues related to the googleapis/java-storage API.
type: process
A process-related concern. May include testing, release, or the like.
Comments
product-auto-label
bot
added
the
api: storage
BenWhitehead
added
the
type: process
|
Thanks for the recommendation. This is something that is on our radar, and it being prioritised along with all of the other Google Cloud Java Libraries. |
|
I may have missed it, but I don't believe you are even using the annotations anywhere in storage, so that dependency can be safely dropped right now. |
gcf-owl-bot bot
added a commit
that referenced
this issue
Feb 1, 2023
…image test run command (#1757) Source-Link: googleapis/synthtool@df311d1 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Feb 2, 2023
…image test run command (#1757) (#1881) Source-Link: https://togithub.com/googleapis/synthtool/commit/df311d1a70b53e86cfeaf0fccf4ded8202deaa6d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb
sydney-munro
added a commit
that referenced
this issue
Mar 7, 2023
* test(deps): update cross product test dependencies (#1868) * chore(main): release 2.17.2 (#1866) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore(deps): update dependency com.google.cloud:google-cloud-storage to v2.17.2 (#1870) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | `2.17.1` -> `2.17.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-storage</summary> ### [`v2.17.2`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#​2172-httpsgithubcomgoogleapisjava-storagecomparev2171v2172-2023-01-23) [Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.17.1...v2.17.2) ##### Bug Fixes - Update BlobReadChannelV2 handling to correctly restart for decompressed object ([#​1867](https://togithub.com/googleapis/java-storage/issues/1867)) ([93e8ed4](https://togithub.com/googleapis/java-storage/commit/93e8ed484224477cd1aeba24b3d84ed4003e9ee6)) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.2 ([#​1865](https://togithub.com/googleapis/java-storage/issues/1865)) ([ceb9a61](https://togithub.com/googleapis/java-storage/commit/ceb9a61921105f6c5dff80f4a1a41a0d3b51a06d)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45Ny42IiwidXBkYXRlZEluVmVyIjoiMzQuOTcuNiJ9--> * chore(main): release 2.17.3-SNAPSHOT (#1869) :robot: I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * test(deps): update cross product test dependencies (#1871) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.5.0 (#1873) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.5.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: add Storage.BlobWriteOption.{meta,}generation{Not,}Match(long) methods to allow literal value construction (#1875) #### New Methods * com.google.cloud.storage.Storage.BlobWriteOption.generationMatch(long) * com.google.cloud.storage.Storage.BlobWriteOption.generationNotMatch(long) * com.google.cloud.storage.Storage.BlobWriteOption.metagenerationMatch(long) * com.google.cloud.storage.Storage.BlobWriteOption.metagenerationNotMatch(long) Update UploadObject sample to use createFrom rather than trying to read the entire file into memory. * chore(java): omit `-Penable-integration-tests` parameter from native image test run command (#1757) (#1881) Source-Link: https://togithub.com/googleapis/synthtool/commit/df311d1a70b53e86cfeaf0fccf4ded8202deaa6d Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ff1a5832623e1b694203b89253dbfe4c2d4a33aae1baf60d323b1245672331eb * feat: setting up 2.15.x (#1880) * feat: setting up 2.15.x * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(deps): update dependency com.google.cloud:libraries-bom to v26.6.0 (#1882) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.6.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * test: update ObjectsFixture to allow discrimination by @BucketFixture (#1876) Sometimes it's useful to specify that the ObjectsFixture should use the RequesterPays bucket * test(deps): update cross product test dependencies (#1885) * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.2.0 (#1886) * test(deps): update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.105.2 (#1888) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-cloud-pubsub-v1](https://togithub.com/googleapis/java-pubsub/proto-google-cloud-pubsub-v1) ([source](https://togithub.com/googleapis/java-pubsub)) | `1.105.1` -> `1.105.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4wIn0=--> * test(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.2 (#1889) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.123.1` -> `1.123.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-pubsub</summary> ### [`v1.123.2`](https://togithub.com/googleapis/java-pubsub/blob/HEAD/CHANGELOG.md#​11232-httpsgithubcomgoogleapisjava-pubsubcomparev11231v11232-2023-02-06) [Compare Source](https://togithub.com/googleapis/java-pubsub/compare/v1.123.1...v1.123.2) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.2.0 ([#​1474](https://togithub.com/googleapis/java-pubsub/issues/1474)) ([5fccae4](https://togithub.com/googleapis/java-pubsub/commit/5fccae49f912a24c14d144fdcc9617d5a5ae110a)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4wIn0=--> * chore(main): release 2.18.0 (#1879) :robot: I have created a release *beep* *boop* --- ## [2.18.0](https://togithub.com/googleapis/java-storage/compare/v2.17.2...v2.18.0) (2023-02-06) ### Features * Add Storage.BlobWriteOption.{meta,}generation{Not,}Match(long) methods to allow literal value construction ([#1875](https://togithub.com/googleapis/java-storage/issues/1875)) ([a9fab09](https://togithub.com/googleapis/java-storage/commit/a9fab098e23c93887f0aae8a5de6e3477d5f0f0c)) * Setting up 2.15.x ([#1880](https://togithub.com/googleapis/java-storage/issues/1880)) ([1c88e83](https://togithub.com/googleapis/java-storage/commit/1c88e83974798d39a63ea4dd85d8f5bb9cb8f88c)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.2.0 ([#1886](https://togithub.com/googleapis/java-storage/issues/1886)) ([6928556](https://togithub.com/googleapis/java-storage/commit/6928556f0a0a61e8c68d9bf98403ce5b27a3bee2)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * chore(deps): update dependency com.google.cloud:google-cloud-storage to v2.18.0 (#1891) * chore(deps): update dependency com.google.cloud:google-cloud-storage to v2.18.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore(main): release 2.18.1-SNAPSHOT (#1890) :robot: I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * fix: update GrpcStorageImpl handling to be aware of quotaProjectId (#1877) Add integration tests to verify desired precedence when resolving userProject options. Fixes #1736 * feat: Update routing annotation for CreateBucketRequest (#1892) * feat: Update routing annotation for CreateBucketRequest * docs: Add support for end-to-end checksumming in the gRPC WriteObject flow * feat!: rename Notification to NotificationConfig PiperOrigin-RevId: 507867795 Source-Link: googleapis/googleapis@604534e Source-Link: googleapis/googleapis-gen@fad2c06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmFkMmMwNmE4N2I5MTA5ODUwZjNlODMyMGEwZWQyN2UxNGIyYTA2NSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: update clirr config * chore: update usages of Notification to NotificationConfig --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: BenWhitehead <[email protected]> * build(deps): update dependency org.apache.maven.plugins:maven-deploy-plugin to v3.1.0 (#1896) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.7.0 (#1897) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.7.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gcp/templates/java_library/.kokoro (#1761) (#1898) * build(deps): bump cryptography Bumps [cryptography](https://togithub.com/pyca/cryptography) from 38.0.3 to 39.0.1. - [Release notes](https://togithub.com/pyca/cryptography/releases) - [Changelog](https://togithub.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://togithub.com/pyca/cryptography/compare/38.0.3...39.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * chore: disabling dependabot --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <[email protected]> Co-authored-by: ddixit14 <[email protected]> Source-Link: https://togithub.com/googleapis/synthtool/commit/0c6f8d4ac5358553ee734e26574f390bc43a736e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5ee35ee919254a3d1e7d4f8abbf1b8c8869ade317ceb2e4df709af1b4b3e9ca1 * chore(deps): update dependency com.google.cloud:libraries-bom to v26.8.0 (#1901) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.8.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * build(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.0.0-m9 (#1902) * build(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.0.0-m9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * deps: update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.20 (#1904) * chore: add feat/breaking-preview branch protection (#1905) * chore: remove cumulative crc32c check on GapicUnbufferedReadableByteChannel (#1903) Cumulative crc32c check is only applicable to an initial offset of 0 because the crc32c value return for a resource is for the entire resource. Instead, we continue to perform the crc32c integrity check for each ChecksummedData which is always for the bytes it is packed with. * fix: update Default RetryStrategy to retry SSLException caused by SocketException (#1900) Update Default RetryStrategy to retry when an SSLException is caused by a SocketException * chore: misc test cleanup (#1899) * Remove DataGeneration rule in favor of Generator fixture from StorageITRunner * Use import on @BucketFixtureAnnotations * Update ITBucketTest#testListBucket to not perform manual retries (Listing buckets is a strongly consistent operation) * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.3.0 (#1907) * test(deps): update cross product test dependencies (#1908) * chore(main): release 2.19.0 (#1894) :robot: I have created a release *beep* *boop* --- ## [2.19.0](https://togithub.com/googleapis/java-storage/compare/v2.18.0...v2.19.0) (2023-02-21) ### Features * Update routing annotation for CreateBucketRequest ([#1892](https://togithub.com/googleapis/java-storage/issues/1892)) ([581120f](https://togithub.com/googleapis/java-storage/commit/581120f00b9adc2d8d45ac038772685d7e134e61)) ### Bug Fixes * Update Default RetryStrategy to retry SSLException caused by SocketException ([#1900](https://togithub.com/googleapis/java-storage/issues/1900)) ([be2aba0](https://togithub.com/googleapis/java-storage/commit/be2aba0704bcdd55fdfeb233802dea532e6c7882)) * Update GrpcStorageImpl handling to be aware of quotaProjectId ([#1877](https://togithub.com/googleapis/java-storage/issues/1877)) ([ca8510e](https://togithub.com/googleapis/java-storage/commit/ca8510e3c16a5cc2fac1499b1888af612aa8e5b2)), closes [#1736](https://togithub.com/googleapis/java-storage/issues/1736) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.3.0 ([#1907](https://togithub.com/googleapis/java-storage/issues/1907)) ([85e22d7](https://togithub.com/googleapis/java-storage/commit/85e22d785b3abef152b2b4df4d394a7477555b08)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.20 ([#1904](https://togithub.com/googleapis/java-storage/issues/1904)) ([95b9aef](https://togithub.com/googleapis/java-storage/commit/95b9aef5fd390a1497bfe6baed3a7200e44f13cf)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * chore(main): release 2.19.1-SNAPSHOT (#1909) :robot: I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * chore(deps): update dependency com.google.cloud:google-cloud-storage to v2.19.0 (#1910) * chore(deps): update dependency com.google.cloud:google-cloud-storage to v2.19.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * test: add new StorageNativeCanaryTest (#1872) Update native-image related config to be specific for this class. Update maven config to explicitly configure this new class as its only class for test when run under -Pnative * build(deps): update releasetool version for release scripts (#1768) (#1911) This should fix release script reporting back to the release PRs Source-Link: googleapis/synthtool@4c15ec0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e62f3ea524b11c1cd6ff7f80362736d86c0056631346b5b106a421686fce2726 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * chore: ignore Update related gRPC tests which are failing due to b/270215524 (#1917) When b/270215524 is fixed and rolled out we should be able to revert this * chore(deps): update dependency com.google.cloud:libraries-bom to v26.9.0 (#1914) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.9.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * test(deps): update cross product test dependencies (#1913) * test(deps): update cross product test dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * feat: allow specifying a negative offset to ReadChannel (#1916) GCS Supports negative offsets in ranged reads and is documented in https://cloud.google.com/storage/docs/json_api/v1/parameters#range Update the ReadChannel returned from Storage.reader to allow providing a negative value to `seek`. NOTE: `seek` to a negative offset will be ignored by GCS if `limit` is also specified * chore(main): release 2.20.0 (#1918) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.4.0 (#1919) * chore(main): release 2.20.1-SNAPSHOT (#1923) :robot: I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please). * chore(main): release 2.20.1 (#1926) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: BenWhitehead <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tomo Suzuki <[email protected]> Co-authored-by: ddixit14 <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the SDK includes a dependency on Animal Sniffer to ensure to no APIs that were introduced post Java 8 are used. This can be replaced by the javac
--releaseargument when building with newer JDKs and the annotations dependency can be removed.As documented on https://www.mojohaus.org/animal-sniffer/
The text was updated successfully, but these errors were encountered: