Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogSplit for logs exceeding maximum size #927

Open
rafal-dudek opened this issue Nov 8, 2022 · 0 comments
Open

Use LogSplit for logs exceeding maximum size #927

rafal-dudek opened this issue Nov 8, 2022 · 0 comments
Labels
api: logging Issues related to the googleapis/java-logging-logback API. logging-resilience priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rafal-dudek
Copy link

Is your feature request related to a problem? Please describe.
In our projects we are using LoggingAppender to write logs in GKE. Some of the logs are bigger than the limit and they are rejected:
ERROR: onFailure exception: com.google.cloud.logging.LoggingException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Log entry with size 293.5K exceeds maximum size of 256.0K

Describe the solution you'd like
LoggingAppender should split the logs exceeding limit and use "split" field described in google.logging.v2 API.

Additional context
LogEntry definition with split field:
https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#logentry
LogSplit definition:
https://cloud.google.com/logging/docs/reference/v2/rpc/google.logging.v2#google.logging.v2.LogSplit
Field definition in proto file:
https://github.com/googleapis/googleapis/blob/master/google/logging/v2/log_entry.proto#L183

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Nov 8, 2022
@losalex losalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. logging-resilience priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 8, 2022
@losalex losalex removed their assignment Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. logging-resilience priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants