Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loggingEventEnhancer is not documented #680

Open
caseyduquettesc opened this issue Feb 9, 2022 · 3 comments
Open

loggingEventEnhancer is not documented #680

caseyduquettesc opened this issue Feb 9, 2022 · 3 comments
Assignees
@cindy-peng
Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@caseyduquettesc
Copy link

The readme only shows <enhancer> in the example configuration, but to use any of the included enhancers, they have to be configured with <loggingEventEnhancer>. It should be added to the example configuration so users are aware the tag exists.

<loggingEventEnhancer>com.google.cloud.logging.logback.MDCEventEnhancer</loggingEventEnhancer>
<loggingEventEnhancer>com.google.cloud.logging.logback.TraceLoggingEventEnhancer</loggingEventEnhancer>
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Feb 9, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 10, 2022
@minherz
Copy link
Contributor

minherz commented Feb 10, 2022

@caseyduquettesc thank you for submitting your request. We have plans to unified the enhancer mechanism. We will align the documentation to the feature changes.

@minherz minherz added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Feb 10, 2022
@minherz minherz assigned minherz and unassigned simonz130 Feb 10, 2022
@daniel-sanche daniel-sanche assigned losalex and unassigned minherz Jul 6, 2022
@daniel-sanche daniel-sanche added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Jul 6, 2022
@losalex losalex removed their assignment Jul 3, 2023
@cindy-peng
Copy link
Contributor

cindy-peng commented Jan 9, 2024 •
edited
Loading

Hi @minherz, thank you for replying to the issue! Could you share more contexts about the unified enhancer mechanism work so I can understand how to proceed on this issue?

@cindy-peng
Copy link
Contributor

Gently Ping, @minherz Is there any work item that I can link this issue to? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@daniel-sanche @minherz @caseyduquettesc @simonz130 @yoshi-automation @losalex @cindy-peng