Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote to 1.0.0 #23

Open
saturnism opened this issue Aug 23, 2018 · 5 comments
Open

Promote to 1.0.0 #23

saturnism opened this issue Aug 23, 2018 · 5 comments
Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@saturnism
Copy link

saturnism commented Aug 23, 2018 •
edited by chingor13
Loading

should prob gated by googleapis/google-cloud-java#3478

See googleapis/java-cloud-bom#470
@sduskis sduskis assigned chingor13 and unassigned chingor13 Jun 7, 2019
@codyoss
Copy link
Member

codyoss commented Oct 1, 2019

@chingor13 It seems like issue blocking this is completed. Should be move forward and make this a beta api?

@chingor13 chingor13 transferred this issue from googleapis/google-cloud-java Jan 7, 2020
@chingor13 chingor13 added the type: process A process-related concern. May include testing, release, or the like. label Jan 7, 2020
@chingor13 chingor13 changed the title bump logback appender to beta Promote to Beta Jan 11, 2020
@google-cloud-label-sync google-cloud-label-sync bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Jan 30, 2020
@chingor13 chingor13 changed the title Promote to Beta Promote to 1.0.0 Nov 12, 2020
@chingor13
Copy link
Contributor

We should mark the surface area as stable. If we need to make backwards incompatible changes, we can bump the semver major.

@keenan-devrel keenan-devrel added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: process A process-related concern. May include testing, release, or the like. labels Nov 13, 2020
@simonz130 simonz130 assigned losalex and unassigned simonz130 Feb 14, 2022
@minherz
Copy link
Contributor

minherz commented Feb 14, 2022

We would like to generalize the logic behind enhancers. Since it might require to deprecate certain configurations it is desirable to make it as a part of the major version increase. Propagating to version 1.0.0 seems to be a good opportunity.

@minherz
Copy link
Contributor

minherz commented Mar 31, 2022

For work on enhancers see googleapis/java-logging#32

@losalex losalex added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 1, 2022
@losalex losalex removed their assignment Jul 3, 2023
@meredithslota meredithslota added the status: blocked Resolving the issue is dependent on other work. label Jul 20, 2023
@meredithslota
Copy link
Contributor

Marking this blocked since we do not plan to promote this to 1.0 without ensuring our overall approach here is more solid. This needs more analysis (re: Min's comment above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: logging Issues related to the googleapis/java-logging-logback API. priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@chingor13 @saturnism @minherz @meredithslota @codyoss @simonz130 @keenan-devrel @losalex