Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix clean up of protected & cdc tables #2445

Merged
merged 2 commits into from
Dec 4, 2024
Merged

test: fix clean up of protected & cdc tables #2445

merged 2 commits into from
Dec 4, 2024

Conversation

igorbernstein2
Copy link
Contributor

Change-Id: Id15852b2b3bbb62746861d7ec02842353612ae77

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
test: fix clean up of protected & cdc tables
13febd2 
Change-Id: Id15852b2b3bbb62746861d7ec02842353612ae77
@igorbernstein2 igorbernstein2 requested review from a team as code owners December 4, 2024 20:10
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 4, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2024
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner December 4, 2024 20:12
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit caa622e into main Dec 4, 2024
22 of 23 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the int-cleanup branch December 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorbernstein2 @mutianf @yoshi-kokoro @cloud-java-bot