Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: Client side metrics opt-out is not honored in BigtableChannelPrimer #2371

Closed
premm01 opened this issue Oct 4, 2024 · 0 comments · Fixed by #2435
Closed

Bigtable: Client side metrics opt-out is not honored in BigtableChannelPrimer #2371

premm01 opened this issue Oct 4, 2024 · 0 comments · Fixed by #2435
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.

Comments

@premm01
Copy link

premm01 commented Oct 4, 2024

Issue
Since 2.38.0, client-side metrics have been enabled by default.
The docs here state that one needs to pass a NoopMetricsProvider.INSTANCE in BigtableDataSettings to opt out of the metrics.
However client side metrics are anyways enabled during channel priming as BigtableChannelPrimer creates its own EnhancedBigtableStubSettings.

Impact
Local testing with Bigtable test container has been impacted by the timeout of 1 minute used in BigtableCloudMonitoringExporter as the exporter is either unable to reach or authenticate with the cloud monitoring endpoint.
Production instances are emitting metrics even if an opt-out was added.

Known workaround
For tests, using the deprecated configuration to disable channel refreshes prevents creation of BigtableChannelPrimer, bypassing the issue.
This option, however, is due to be removed in future.

Bigtable library version
2.44.0 but all versions since 2.38.0 should be affected

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant