Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mini_mime? #3408

Closed
blowmage opened this issue May 21, 2019 · 1 comment · Fixed by #3732
Closed

Switch to mini_mime? #3408

blowmage opened this issue May 21, 2019 · 1 comment · Fixed by #3732
Assignees
@blowmage
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@blowmage
Copy link
Contributor

The google-api-client gem recently switched from mime_types to mini_mime. Should the BigQuery and Storage gems, which currently use mime_types, also switch?
@blowmage blowmage added api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. labels May 21, 2019
@quartzmo
Copy link
Member

Discussion of mime_types and memory usage

blowmage added a commit to blowmage/google-cloud-ruby that referenced this issue Aug 2, 2019
@blowmage
Use MiniMime to detect content types
115f3fb 
This dependency uses less resources that mime-types.

[closes googleapis#3408]
@blowmage blowmage mentioned this issue Aug 2, 2019
Merged
blowmage added a commit that referenced this issue Aug 2, 2019
@blowmage
perf: Use MiniMime to detect content types
32cbf03 
The mini_mime dependency uses less resources that mime-types.

[pr #3732, closes #3408]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blowmage blowmage

Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use MiniMime to detect content types blowmage/google-cloud-ruby
2 participants
@blowmage @quartzmo