New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Bigtable clients to be closed, per conformance tests #25822

Open

meagar opened this issue Apr 29, 2024 · 0 comments

Assignees

Contributor

meagar commented Apr 29, 2024 •

edited

Loading

The Ruby Bigtable client should support being "closed", such that new requests are rejected, but in-flight requests are allowed to complete.

Context:

Bigtable clients are tested for "conformance" against the language-independent test suite defined via https://github.com/googleapis/cloud-bigtable-clients-test

This test suite requires that Bigtable clients should be closable, and that closing a connection should allow in-flight requests to complete, but prevent the connection from accepting new requests (ie https://github.com/googleapis/cloud-bigtable-clients-test/blob/main/tests/readrow_test.go#L241)

Issue created per https://github.com/googleapis/google-cloud-ruby/pull/25680/files#r1581587707.

blunderbuss-gcf bot assigned dazuma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment