Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop showing irrelevant artifacts in Dependency Dashboard #8503

Closed
suztomo opened this issue Oct 3, 2022 · 6 comments
Closed

Stop showing irrelevant artifacts in Dependency Dashboard #8503

suztomo opened this issue Oct 3, 2022 · 6 comments
Assignees
@meltsufin
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 3, 2022 •
edited
Loading

We need google-cloud-shared-dependencies in #7649 . But it's not showing it due to a number of artifacts listed there. Most of them are unnecessary. (Why unnecessary? See #8239)

Screen Shot 2022-10-03 at 10 35 27 AM
@suztomo suztomo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 3, 2022
@suztomo
Copy link
Member Author

suztomo commented Oct 3, 2022

@ddixit14 Can you check this when you have time. (Not high priority for now)

@meltsufin meltsufin assigned meltsufin and unassigned ddixit14 Oct 4, 2022
@meltsufin
Copy link
Member

I'll take this one.

@meltsufin meltsufin mentioned this issue Oct 5, 2022
Merged
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2022 •
edited
Loading

@meltsufin All we want here may be the 1st attempt by Deepankar:

1c20a75

If this takes time (such as few hours), I think I can come up with awk command that does the job for google-cloud-shared-dependencies. This would unblock 10 owl-bot-copy pull requests in the pull request queue. https://github.com/googleapis/google-cloud-java/pulls?q=is%3Apr+is%3Aopen+label%3Aowl-bot-copy

@meltsufin
Copy link
Member

1c20a75 is fine as a temporary fix. I'm working on a more permanent fix in #8521.

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2022

Working on the short term fix.

@suztomo suztomo mentioned this issue Oct 5, 2022
Merged
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2022

Now I can see google-cloud-shared-dependencies in Dependency Dashboard:

Screen Shot 2022-10-05 at 12 45 12 PM

@suztomo suztomo closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltsufin meltsufin

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @meltsufin @ddixit14