Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Export symbols of apiv2/storagepb #11163

Open
AndreasBergmeier6176 opened this issue Nov 21, 2024 · 4 comments
Open

storage: Export symbols of apiv2/storagepb #11163

AndreasBergmeier6176 opened this issue Nov 21, 2024 · 4 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@AndreasBergmeier6176
Copy link

Is your feature request related to a problem? Please describe.

Previously it was not easily possible to write unit testing against cloud storage bindings. With the new GRPC API this is now possible. Currently though one must fork this repo and export the internal symbols manually.

Describe the solution you'd like

It would be better to have the generated symbols publicly accessible.

Describe alternatives you've considered

Since bindings get statically registered upon loading not sure whether there is really any alternative.

Additional context

Not sure how migration could happen since currently the reflection path is used in registering. Changing this path might lead to other problems?

@AndreasBergmeier6176 AndreasBergmeier6176 added the triage me I really want to be triaged. label Nov 21, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 21, 2024
@tritone tritone added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Nov 21, 2024
@tritone
Copy link
Contributor

tritone commented Nov 21, 2024

@codyoss what do you think about this?

The storage/v2 API recently hit GA so I wouldn't be opposed at this point.

@kazegusuri
Copy link

Same situation at this issue. When I create another pb files from proto for apiv2.storagepb for testing instead of using generated files provided by google-cloud-go, the namespace conflict happens. So we cannot create a mock or fake server for storagev2.

@AndreasBergmeier6176
Copy link
Author

For the time being you can use our fork here: https://github.com/AndreasBergmeier6176/google-cloud-go

Need replace cloud.google.com/go/storage => github.com/AndreasBergmeier6176/google-cloud-go/storage v1.47.2 then.

@codyoss
Copy link
Member

codyoss commented Nov 26, 2024

@tritone Seems reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants