Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup (storage): Remove gRPC version guards from async_throughput_benchmark.cc #14750

Open
ddelgrosso1 opened this issue Oct 1, 2024 · 0 comments
Open

Cleanup (storage): Remove gRPC version guards from async_throughput_benchmark.cc #14750

ddelgrosso1 opened this issue Oct 1, 2024 · 0 comments
Assignees
@ddelgrosso1
Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.

Comments

@ddelgrosso1
Copy link
Contributor

MSVC + VCPKG + gRPC (<1.65.4) have some compilation issues (See: grpc/grpc#35297). As a result I added a version guard to async_throughput_benchmark.cc. This should be removed once the version in VCPKG is updated (See: microsoft/vcpkg#39800).
@ddelgrosso1 ddelgrosso1 added api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern. labels Oct 1, 2024
@ddelgrosso1 ddelgrosso1 self-assigned this Oct 1, 2024
@ddelgrosso1 ddelgrosso1 mentioned this issue Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
api: storage Issues related to the Cloud Storage API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove guards now that vcpkg has grpc 1.65.5 ddelgrosso1/google-cloud-cpp
1 participant
@ddelgrosso1