Audit additional_proto_files
#14518
Labels
cpp: generator
Issues related to the C++ micro-generator
type: cleanup
An internal cleanup or hygiene concern.
LROs have an annotation for their returned metadata type. Proto syntax does not require
import
s for the proto files that define these metadata types. In C++ we have to include these files.Our intention for
additional_proto_files
was to add includes for these extra*.pb.h
headers.Turns out that when we feed them into
protoc
we treat them the same as any other service's proto file.google-cloud-cpp/generator/standalone_main.cc
Lines 314 to 317 in a86e887
This leads to some weirdness in the generator config. In
notebooks
andrun
, we rely on this behavior to generate some clients (and avoid #7997). Incontaineranalysis
, we accidentally generate a client forgrafeas
which we did not intend to. Oops.We should sort this out.
The text was updated successfully, but these errors were encountered: