Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AsyncPollingLoop to accept an Operation directly #14336

Open
scotthart opened this issue Jun 14, 2024 · 0 comments
Open

Refactor AsyncPollingLoop to accept an Operation directly #14336

scotthart opened this issue Jun 14, 2024 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

Currently in AsyncAwaitLongRunningOperation we can construct a future<StatusOr<Operation>> from an Operation just so we can pass it to AsyncPollingLoop. It would be preferable to refactor AsyncPollingLoop such that it could accept either.

A brief attempt to do this refactoring was made, but resulted in unit test failures when trying to cancel the future.
@scotthart scotthart added the type: cleanup An internal cleanup or hygiene concern. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scotthart