Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hurley author is shutting down his project #336

Closed
xeron opened this issue Jan 16, 2016 · 18 comments
Closed

Hurley author is shutting down his project #336

xeron opened this issue Jan 16, 2016 · 18 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Milestone

Comments

@xeron
Copy link

xeron commented Jan 16, 2016

Just wondering if it will be an issue in the future.

lostisland/hurley#43

@sqrrrl
Copy link
Contributor

sqrrrl commented Jan 19, 2016

Thanks for the heads up. It's not the end of the world since Hurley isn't directly exposed in the API. I'll likely just switch to use HTTPClient directly. Faraday doesn't yet support streaming responses yet which is a problem for APIs like Drive, Storage, etc. that can return large media blobs.

@cedricpim
Copy link

Hi @sqrrrl, any estimation when this switch is going to happen?
I was trying to update to the new version of the gem but my tests are relying on VCR which does not support Hurley and was wondering if it is worth it to look into that or wait.

Thanks.

@sqrrrl
Copy link
Contributor

sqrrrl commented Feb 3, 2016

You should be able to use VCR via webmock today. Hurley & Faraday are just wrappers around other HTTP client libraries. Right now I have Hurley wired to use HTTPClient, and from a VCR perspective just treat the library as if it were using HTTPClient directly.

As for switching off Hurley, I have another branch locally where I'm making some changes to get rid of it. Mostly there (all but 2 tests pass) but not in any rush to get it done.

@cedricpim
Copy link

I ended up noticing the problem was not specifically with Hurley but I think might be with the streaming (VCR body of the response is empty).
Thanks 👍

@sqrrrl
Copy link
Contributor

sqrrrl commented Feb 5, 2016

FYI, pushed the first pass of this on branch httpclient. Still need to do a lot more testing (specifically batching) against some live APIs, but it's there if anyone is curious and wants to try it out.

@jharbert
Copy link

👍 @sqrrrl - Tested the httpclient branch against my code and all seems well, it also fixes the VCR issues described above. Will keep testing it out.

@icco
Copy link
Contributor

icco commented Feb 12, 2016

I'll give this a try on fog-google.

@cedricpim
Copy link

Regarding the VCR issues, a fix was merged into webmock master branch and it is working good from it. This was the fix: bblimke/webmock#582

@sqrrrl
Copy link
Contributor

sqrrrl commented Feb 12, 2016

Thanks!

@blowmage
Copy link
Contributor

Is moving from Hurley to HTTPClient still going to happen?

@sqrrrl
Copy link
Contributor

sqrrrl commented Jun 22, 2016

Yes, just waiting for the next release of HTTPClient which contains a fix I need for resumable media downloads to work correctly.

@sqrrrl sqrrrl modified the milestone: 0.10 Aug 17, 2016
@sqrrrl
Copy link
Contributor

sqrrrl commented Aug 18, 2016

Hurley removed in v0.10 branch

@sqrrrl sqrrrl closed this as completed Aug 18, 2016
@blowmage
Copy link
Contributor

@sqrrrl Is there a timeline for a v0.10 release?

@sqrrrl
Copy link
Contributor

sqrrrl commented Aug 18, 2016

Not sure. Maybe 2 or 3 weeks.

@JanStevens
Copy link

Any update on this? Hurley is not maintained at all and pretty much dead.
Also any google project lib uses this client.

Excon is a pretty good alternative?

@TheCorp
Copy link

TheCorp commented Mar 10, 2017

We're on 0.11 now and I still see Hurley being used, can you comment on the status?

@saicheems
Copy link
Contributor

I'll get this done as soon as I can

@TheCorp
Copy link

TheCorp commented Mar 10, 2017

Awesome thanks!

@saicheems saicheems self-assigned this Mar 10, 2017
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

10 participants