-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hurley author is shutting down his project #336
Comments
Thanks for the heads up. It's not the end of the world since Hurley isn't directly exposed in the API. I'll likely just switch to use HTTPClient directly. Faraday doesn't yet support streaming responses yet which is a problem for APIs like Drive, Storage, etc. that can return large media blobs. |
You should be able to use VCR via webmock today. Hurley & Faraday are just wrappers around other HTTP client libraries. Right now I have Hurley wired to use HTTPClient, and from a VCR perspective just treat the library as if it were using HTTPClient directly. As for switching off Hurley, I have another branch locally where I'm making some changes to get rid of it. Mostly there (all but 2 tests pass) but not in any rush to get it done. |
I ended up noticing the problem was not specifically with Hurley but I think might be with the streaming (VCR body of the response is empty). |
FYI, pushed the first pass of this on branch httpclient. Still need to do a lot more testing (specifically batching) against some live APIs, but it's there if anyone is curious and wants to try it out. |
👍 @sqrrrl - Tested the httpclient branch against my code and all seems well, it also fixes the VCR issues described above. Will keep testing it out. |
I'll give this a try on fog-google. |
Regarding the VCR issues, a fix was merged into webmock master branch and it is working good from it. This was the fix: bblimke/webmock#582 |
Thanks! |
Is moving from Hurley to HTTPClient still going to happen? |
Yes, just waiting for the next release of HTTPClient which contains a fix I need for resumable media downloads to work correctly. |
Hurley removed in v0.10 branch |
@sqrrrl Is there a timeline for a v0.10 release? |
Not sure. Maybe 2 or 3 weeks. |
Any update on this? Hurley is not maintained at all and pretty much dead. Excon is a pretty good alternative? |
We're on 0.11 now and I still see Hurley being used, can you comment on the status? |
I'll get this done as soon as I can |
Awesome thanks! |
Just wondering if it will be an issue in the future.
lostisland/hurley#43
The text was updated successfully, but these errors were encountered: