chore: Use a vanilla reference in net462 for System.Management #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib/net462 folder in System.Management version 7.0.2 is empty, so this *should* be equivalent.
amanda-tarafa
added
the
do not merge
|
Addind the |
amanda-tarafa
removed
the
do not merge
|
I can see no reason why we had the versioned package reference vs. the .NET Framework reference. Also, I've ran several tests including from applications targetting both .NET Framework 4.6.2 and .NET Framework 4.8 with Google.Apis.Auth depending on the .NET Framework reference of System.Management and everything works fine. This should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lib/net462 folder in System.Management version 7.0.2 is empty, so this should be equivalent.
Addresses #2820.