Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option add-iam-methods #2255

Open
parthea opened this issue Nov 19, 2024 · 0 comments
Open

Remove option add-iam-methods #2255

parthea opened this issue Nov 19, 2024 · 0 comments
Assignees

Comments

@parthea
Copy link
Contributor

parthea commented Nov 19, 2024

The add-iam-methods option and corresponding nox session showcase_unit_add_iam_methods should be removed from the codebase as it is redundant code.

'add-iam-methods', # microgenerator implementation for `reroute_to_grpc_interface`

with showcase_library(session, other_opts=("add-iam-methods",)) as lib:

Before it can be removed, we need to remove usage of it here:
https://github.com/search?q=repo%3Agoogleapis%2Fgoogleapis%20add-iam-methods&type=code

We shouldn't need the add-iam-methods as mentioned in #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants