Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low code coverage in gapic-generator-python file causing code coverage presubmits in wrapper libraries to fail #2229

Open
mukund-ananthu opened this issue Oct 18, 2024 · 1 comment
Open

Low code coverage in gapic-generator-python file causing code coverage presubmits in wrapper libraries to fail #2229

mukund-ananthu opened this issue Oct 18, 2024 · 1 comment
Assignees
@vchudnov-g

Comments

@mukund-ananthu
Copy link

Refer https://screenshot.googleplex.com/7n9pwMTghidPyZy and https://github.com/googleapis/python-pubsub/actions/runs/11284569910/job/31386013263?pr=1274

The code coverage is less than 100% and the presubmits in the wrapper library, that expect a 100% coverage fail, disallowing us to submit other PRs in that repository(unless we circumvent the expectation of 100% coverage which is not ideal)
@mukund-ananthu
Copy link
Author

cc: @parthea

mukund-ananthu added a commit to googleapis/python-pubsub that referenced this issue Oct 18, 2024
@mukund-ananthu
fix: Reduce the code coverage percentage to 99
9e63283 
* Currently, the code coverage presubmits are failing because of this
  issue in the gapic-generator-python library: googleapis/gapic-generator-python#2229
@mukund-ananthu mukund-ananthu mentioned this issue Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchudnov-g vchudnov-g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchudnov-g @mukund-ananthu