Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a stronger type hint for credentials parameter in base rest transport #2173

Open
ohmayr opened this issue Sep 17, 2024 · 0 comments
Open

Add a stronger type hint for credentials parameter in base rest transport #2173

ohmayr opened this issue Sep 17, 2024 · 0 comments
Assignees
@ohmayr
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 17, 2024

The credentials parameter in base rest transport has a type hint set to Any to support async and sync credential types in the parent rest transport classes. However, we should have a stronger type here such as an abstract base credentials class leveraged by sync and async credential classes.
@ohmayr ohmayr added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 18, 2024
This was referenced Sep 19, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update type hints for credentials googleapis/gapic-generator-python
1 participant
@ohmayr