Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #148

Open
vchudnov-g opened this issue Jun 4, 2020 · 0 comments
Open

Fix failing tests #148

vchudnov-g opened this issue Jun 4, 2020 · 0 comments
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@vchudnov-g
Copy link
Contributor

The following tests fail on my local machine. I think we've been ignoring test failures recently during sample generation, but this makes it hard to verify that necessary changes work as intended. We should fix or formally disable these tests.


com.google.api.codegen.advising.AdviserTest > missing_package_name FAILED
    java.lang.IllegalArgumentException at AdviserTest.java:86

com.google.api.codegen.advising.AdviserTest > missing_language_settings FAILED
    java.lang.IllegalArgumentException at AdviserTest.java:63

com.google.api.codegen.metacode.SampleInitCodeTest > testSimpleField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testFormattedFieldBadFieldWithValue FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testNestedListField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testBadField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMultipleListEntries FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListFieldMismatchedFieldThenList FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListEmbeddedField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testRegex FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMultipleFields FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testBadSubField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListFieldIndexGap FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testCompoundingStructureList FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testEmbeddedFieldList FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testAssignment FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListEmbeddedMultipleFields FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMultipleMapEntries FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMapField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMapFieldBadStringIndexUnclosedDoubleQuotes FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMapFieldBadIntIndex FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testEmbeddedField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testFormattedFieldBadField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMultipleFormattedEntries FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testFormattedField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListFieldBadIndex FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testListFieldMismatchedListThenField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testMapFieldBadStringIndexUnclosedSingleQuotes FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testCompoundingStructure FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testNestedMixedField FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.metacode.SampleInitCodeTest > testFormattedFieldWithValues FAILED
    java.lang.IllegalArgumentException at SampleInitCodeTest.java:54

com.google.api.codegen.transformer.php.PhpModelTypeNameConverterTest > testGetEnumValue FAILED
    java.lang.IllegalArgumentException at PhpModelTypeNameConverterTest.java:33

com.google.api.codegen.transformer.nodejs.NodeJSModelTypeNameConverterTest > testGetEnumValue FAILED
    java.lang.IllegalArgumentException at NodeJSModelTypeNameConverterTest.java:33

com.google.api.codegen.transformer.go.GoModelTypeNameConverterTest > testGetEnumValue FAILED
    java.lang.IllegalArgumentException at GoModelTypeNameConverterTest.java:54

com.google.api.codegen.transformer.go.GoGapicSurfaceTransformerTest > classMethod FAILED
    java.lang.IllegalArgumentException at GoGapicSurfaceTransformerTest.java:50

com.google.api.codegen.transformer.csharp.CSharpModelTypeNameConverterTest > testGetEnumValue FAILED
    java.lang.IllegalArgumentException at CSharpModelTypeNameConverterTest.java:33

com.google.api.codegen.transformer.ruby.RubyModelTypeNameConverterTest > testGetEnumValue FAILED
    java.lang.IllegalArgumentException at RubyModelTypeNameConverterTest.java:33

com.google.api.codegen.GapicCodeGeneratorTest > library[go] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[php] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[java] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[java] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[ruby] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[ruby_doc] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[ruby] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[ruby] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[py] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[py] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[nodejs] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[nodejs_doc] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[nodejs] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[nodejs] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[csharp] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.GapicCodeGeneratorTest > library[client_config] FAILED
    java.lang.IllegalArgumentException at GapicCodeGeneratorTest.java:148

com.google.api.codegen.ConfigGenerationTest > longrunning FAILED
    java.lang.IllegalArgumentException at ConfigGenerationTest.java:75

com.google.api.codegen.ConfigGenerationTest > library FAILED
    java.lang.IllegalArgumentException at ConfigGenerationTest.java:65

com.google.api.codegen.ConfigGenerationTest > no_path_templates FAILED
    java.lang.IllegalArgumentException at ConfigGenerationTest.java:70

com.google.api.codegen.grpcmetadatagen.PackageMetadataGeneratorTest > python_library FAILED
    java.lang.IllegalArgumentException at PackageMetadataGeneratorTest.java:69

com.google.api.codegen.grpcmetadatagen.PackageMetadataGeneratorTest > java_grpc_stubs FAILED
    java.lang.IllegalArgumentException at PackageMetadataGeneratorTest.java:69

com.google.api.codegen.grpcmetadatagen.PackageMetadataGeneratorTest > java_library FAILED
    java.lang.IllegalArgumentException at PackageMetadataGeneratorTest.java:69

com.google.api.codegen.grpcmetadatagen.PackageMetadataGeneratorTest > java_common_protos FAILED
    java.lang.IllegalArgumentException at PackageMetadataGeneratorTest.java:69
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 4, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Sep 2, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Dec 1, 2020
@dazuma dazuma added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dazuma @vchudnov-g @yoshi-automation