Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When discoveries change, regenerate corresponding samples into new PR #140

Open
vchudnov-g opened this issue Mar 12, 2020 · 0 comments
Open
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Mar 12, 2020

In order for us to update samples more proactively, let's implement the following:

After syncing new Discoveries, our nightly job should re-generate samples

  • for any Discoveries that have changed, or
  • if any of the code in this repo has changed.

If those new samples are different than the corresponding existing samples, the new samples should go into a PR for review by the owners of this repo.

The owners of this repo will thus be automatically notified when new samples need to be published. After approving and merging the PR, we can then pull it into our local workspaces and push the new samples to GCS where they can be visible to the world.

@vchudnov-g vchudnov-g added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 12, 2020
@yihanzhen yihanzhen assigned vchudnov-g and unassigned yihanzhen Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants