Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enum unspecified value" rule inaccurate to AIP #1273

Open
mbleigh opened this issue Oct 17, 2023 · 0 comments
Open

"Enum unspecified value" rule inaccurate to AIP #1273

mbleigh opened this issue Oct 17, 2023 · 0 comments

Comments

@mbleigh
Copy link

mbleigh commented Oct 17, 2023

Steps to reproduce

  1. Write an enum with a meaningful zero value
  2. Enable strict API linter
  3. Linter flags missing _UNSPECIFIED value

The issue here is that the AIP itself has an exception for a "clearly useful zero value". This means that even in the strict API linter it should be possible to have an enum with a meaningful zero value because it's an exception to the rule, not just an ignored should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant