Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Migrate to Dialogflow v2? #2

Open
jeremykeen opened this issue May 1, 2018 · 5 comments
Open

Migrate to Dialogflow v2? #2

jeremykeen opened this issue May 1, 2018 · 5 comments

Comments

@jeremykeen
Copy link
Contributor

Do you intend to migrate the code to Dialogflow V2?

@mikedory
Copy link
Member

mikedory commented May 2, 2018

Hey @jeremykeen — we do indeed, but we'd also welcome any contributions meantime.

@priyanktyagi89
Copy link

priyanktyagi89 commented May 22, 2018

@mikedory : I just found that you are storing id of intent of your agent in github. I think, it might put your agent on risk.

I mean https://github.com/google/voice-iot-maker-demo/blob/master/dialogflow-agent/voice-iot-maker-demo/intents/Default%20Fallback%20Intent.json

{ "id": "ac2178f6-e492-48e0-b7b2-72560279254a", "name": "Default Fallback Intent", "auto": false,

@mikedory
Copy link
Member

Hey @priyanktyagi89 — thanks for calling that out. That ID corresponds to a sample app, and should be replaced when you import the app via Dialogflow. However, happy to accept a pull request to remove the ID, if you'd like to send one.

@avidan
Copy link

avidan commented Feb 15, 2020

i'd also love to see this migrated for V2. this was powering my particle powered vending machine: https://twitter.com/kane/status/1129451259860099072?s=20

i am doing my best to learn about V1 to V2 migration requirements so i can build a pull request, but so far its slow going :)

thanks for what you built thus far Mike! if you find yourself in SF, know there is an automated beer waiting for you

@mikedory
Copy link
Member

@avidan That'd be awesome! Please do send a pull request if you end up getting it working.

And that's too kind, thank you much! Waving a non-automated hello back from the east coast. 👋 😂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants